[PATCH 4/7] drm/msm/dp: restore source params and reinit video_comp on link maintenance
From: Gianfranco Mariotti
Date: Sat Nov 21 2026 - 16:41:31 EST
In msm_dp_ctrl_link_maintenance(), msm_dp_ctrl_setup_main_link() calls
msm_dp_ctrl_config_ctrl_link(), which resets REG_DP_CONFIGURATION_CTRL
to 6 bpc without restoring the active stream's BPC and format via
msm_dp_ctrl_configure_source_params(). In addition, ctrl->video_comp is
not reinitialized before waiting for video ready.
Reinitialize ctrl->video_comp before retraining the link and restore
source parameters via msm_dp_ctrl_configure_source_params() before
switching REG_DP_STATE_CTRL to DP_STATE_CTRL_SEND_VIDEO.
Fixes: 0a19867dfb8d ("drm/msm/dp: split link setup from source params")
Signed-off-by: Gianfranco Mariotti <gianfranco.mariotti94@xxxxxxxxx>
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
index 779f743f9418..0904893bd529 100644
--- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
+++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
@@ -2094,10 +2094,14 @@ static int msm_dp_ctrl_link_maintenance(struct msm_dp_ctrl_private *ctrl,
ctrl->link->phy_params.p_level = 0;
ctrl->link->phy_params.v_level = 0;
+ reinit_completion(&ctrl->video_comp);
+
ret = msm_dp_ctrl_setup_main_link(ctrl, panel, &training_step);
if (ret)
goto end;
+ msm_dp_ctrl_configure_source_params(ctrl, panel);
+
msm_dp_ctrl_clear_training_pattern(ctrl, panel, DP_PHY_DPRX);
msm_dp_write_link(ctrl, REG_DP_STATE_CTRL, DP_STATE_CTRL_SEND_VIDEO);
--
2.25.1