Re: [PATCH] md/raid5: complete unsupported discards successfully
From: Konstantin Nikiforov
Date: Sat Nov 21 2026 - 16:21:25 EST
Hi Kuai,
I built and tested md-7.5 with b964c9240a37 on the machine from the
regression report. The reproducer passes and the machine runs without
backing-device errors.
Tested tree
-----------
md-7.5 tip c526b7cd32f7, based on v7.4-rc2, with b964c9240a37 applied.
Built as 7.4.0-rc2-md75+ (x86_64, Arch config, gcc 16.2.1) and booted
on the affected machine.
Reproducer
----------
Three 256M loop files -> raid5 (64K chunk, metadata 1.2) -> bcache
backing device. devices_handle_discard_safely is left at its default
(N), so the array takes the raid5_discard_limits() path changed by the
patch.
md125: discard_max_bytes=2199023255040, discard_granularity=131072
blkdiscard 8M on md125: exit 0
bcache1 over md125: discard_max_bytes=2199023255040
4x blkdiscard 8M on bcache1: io_errors=0, no
bch_count_backing_io_errors lines in dmesg
The same reproducer gave io_errors=4 with the unpatched 7.2.11 module.
With the patched 7.2.11 module, and now with this kernel, it stays 0.
Affected machine
----------------
3x ST1000DM010 (no TRIM) -> md126 raid5 -> bcache0 (NVMe cache
attached, writethrough) -> LVM -> ext4/btrfs root.
Since booting 7.4.0-rc2-md75+, md126 and md127 are [UUU],
/sys/block/bcache0/bcache/io_errors is 0, and dmesg has no
bch_count_backing_io_errors or md/bcache I/O errors.
Caveat: the local workaround (udev rule zeroing discard_max_bytes on
md*/bcache*, plus nodiscard mounts) is still in the initramfs, so the
HDD-backed array has not received discards on this boot. The loop
reproducer is what exercises the changed code path. I can do a
no-workaround boot and a scratch-LV discard test if you want that
before this goes to stable.
Note: 7.2.y is EOL (7.2.15, 2026-11-01), so the "Cc: stable # 7.2" is
stale; v7.3.5 still has the old code, so the fix is needed in 7.3.y
once this reaches mainline.
Tested-by: Konstantin Nikiforov <helllamer@xxxxxxxxx>
#regzbot fix: md/raid5: complete unsupported discards successfully
Thanks,
Konstantin
DeepSeek Harness 0.2.2-rc.5; model: deepseek-flash