Re: [PATCH 5/8] platform: dell: smbios-wmi: Fix probe on RTX Spark

From: Armin Wolf

Date: Sat Nov 21 2026 - 08:44:46 EST


Am 21.11.26 um 01:05 schrieb Brian Mak:

dell-smbios-wmi fails to probe on RTX Spark due to a hardcoded SMBIOS
handle (0xB100) of type 0xB1 (misc BIOS flags) that is numbered
differently on Dell RTX Spark laptops. Instead, search for all SMBIOS
handles of type 0xB1, and if there is just one, use that one. If handle
0xB100 exists, always use that.

This fixes dell-smbios-wmi probe on Dell RTX Spark laptops.

Hi,

i think you can drop the special handling of handle 0xB100 and instead
just check if the SMBIOS type is 0xB1. AFAIK the PCI code also parses
some parts of the 0xB1 type, and there the handle value is irrelevant.

Thanks,
Armin Wolf

Signed-off-by: Brian Mak <bmak@xxxxxxxxxx>
---
drivers/platform/dell/dell-smbios-wmi.c | 37 +++++++++++++++++++------
1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/drivers/platform/dell/dell-smbios-wmi.c b/drivers/platform/dell/dell-smbios-wmi.c
index 7a5c6d7730ab..ff859d9039b9 100644
--- a/drivers/platform/dell/dell-smbios-wmi.c
+++ b/drivers/platform/dell/dell-smbios-wmi.c
@@ -273,7 +273,13 @@ static const struct wmi_device_id dell_smbios_wmi_id_table[] = {
{ },
};
-static void parse_b1_table(const struct dmi_header *dm)
+struct b1_search {
+ bool found_b100;
+ unsigned int count;
+ u16 flags0;
+};
+
+static void parse_b1_table(const struct dmi_header *dm, struct b1_search *search)
{
struct misc_bios_flags_structure *flags =
container_of(dm, struct misc_bios_flags_structure, header);
@@ -281,17 +287,21 @@ static void parse_b1_table(const struct dmi_header *dm)
/* 4 bytes header, 8 bytes flags */
if (dm->length < 12)
return;
- if (dm->handle != 0xb100)
- return;
- if ((flags->flags0 & FLAG_HAS_ACPI_WMI))
- wmi_supported = 1;
+
+ search->count++;
+ if (dm->handle == 0xb100) {
+ search->found_b100 = true;
+ search->flags0 = flags->flags0;
+ } else if (!search->found_b100) {
+ search->flags0 = flags->flags0;
+ }
}
-static void find_b1(const struct dmi_header *dm, void *dummy)
+static void find_b1(const struct dmi_header *dm, void *data)
{
switch (dm->type) {
case 0xb1: /* misc bios flags */
- parse_b1_table(dm);
+ parse_b1_table(dm, data);
break;
}
}
@@ -308,7 +318,18 @@ static struct wmi_driver dell_smbios_wmi_driver = {
int init_dell_smbios_wmi(void)
{
- dmi_walk(find_b1, NULL);
+ struct b1_search search = {};
+
+ dmi_walk(find_b1, &search);
+
+ /*
+ * Dell x86 firmware places the misc BIOS flags at handle 0xb100. However,
+ * with RTX Spark, it is not at handle 0xb100, so fall back to the only type
+ * 0xb1 handle present if there is only one.
+ */
+ if ((search.found_b100 || search.count == 1) &&
+ (search.flags0 & FLAG_HAS_ACPI_WMI))
+ wmi_supported = 1;
if (!wmi_supported)
return -ENODEV;