Re: [PATCH 4/4] PCI/AER: Hide the "aer" sysfs directory on devices without AER
From: Bjorn Helgaas
Date: Fri Nov 20 2026 - 20:31:42 EST
[+cc Lukas]
On Tue, Nov 10, 2026 at 03:56:14PM -0600, Yazen Ghannam wrote:
> aer_attr_group is a named group, so sysfs creates an "aer" directory for
> every PCI device. aer_attrs_are_visible() hides the attributes when the
> device has no aer_info.
>
> But this doesn't apply to the entire "aer" group. So devices without AER
> end up having an empty "aer" directory.
This applies specifically to the ratelimit-related things in the "aer"
directory, right? If so I might amend this commit log to mention
that, since Lukas's subsequent "PCI/AER: Enable baseline capability
error reporting" enables aer_dev_correctable, aer_dev_fatal, etc even
for non-AER PCIe devices.
"aer_attrs" and "aer_attr_group" are kind of unfortunate names since
they're specific to ratelimiting. But that's material for future
work.
At least they're internal so they're easier to change than
"aer_dev_correctable" etc, which are even more unfortunate now.
> Switch to DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE() which can use a single
> check for all the AER attributes.
>
> Fixes: b4fe7398def6 ("PCI/AER: Add sysfs attributes for log ratelimits")
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-pci/20260714191826.BA81E1F000E9@xxxxxxxxxxxxxxx/
> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> ---
> drivers/pci/pcie/aer.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index 32a4c9101946..5ea81a506a06 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -778,22 +778,19 @@ static struct attribute *aer_attrs[] = {
> NULL
> };
>
> -static umode_t aer_attrs_are_visible(struct kobject *kobj,
> - struct attribute *a, int n)
> +static bool aer_group_visible(struct kobject *kobj)
> {
> - struct device *dev = kobj_to_dev(kobj);
> - struct pci_dev *pdev = to_pci_dev(dev);
> + struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));
>
> - if (!pdev->aer_info)
> - return 0;
> -
> - return a->mode;
> + return !!pdev->aer_info;
> }
>
> +DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(aer);
> +
> const struct attribute_group aer_attr_group = {
> .name = "aer",
> .attrs = aer_attrs,
> - .is_visible = aer_attrs_are_visible,
> + .is_visible = SYSFS_GROUP_VISIBLE(aer),
> };
>
> static void pci_dev_aer_stats_incr(struct pci_dev *pdev,
> --
> 2.55.0
>