Re: [PATCH 6/8] platform: dell: smbios: Add quirk for non-functional calling interface

From: Pali Rohár

Date: Fri Nov 20 2026 - 19:38:43 EST


On Friday 20 November 2026 16:05:52 Brian Mak wrote:
> On Dell RTX Spark laptops, the SMBIOS calling interface completes every
> request with an all-zero buffer, even for requests that should fail.
> Drivers that rely on it, such as dell-laptop and dell-pc, end up
> reporting bogus state, like battery charge modes and thermal modes.

Hello, is Dell aware of this firmware issue? And it is going to be fixed?

> Add a DMI quirk list for platforms with a non-functional calling
> interface, and export dell_smbios_calls_functional() so that consumers
> can avoid loading on them. dell-smbios itself still loads, as dell-wmi
> depends on it.
>
> Signed-off-by: Brian Mak <bmak@xxxxxxxxxx>
> ---
> drivers/platform/dell/dell-smbios-base.c | 22 ++++++++++++++++++++++
> drivers/platform/dell/dell-smbios.h | 1 +
> 2 files changed, 23 insertions(+)
>
> diff --git a/drivers/platform/dell/dell-smbios-base.c b/drivers/platform/dell/dell-smbios-base.c
> index c8e93c12c445..e07cbb0e8a6a 100644
> --- a/drivers/platform/dell/dell-smbios-base.c
> +++ b/drivers/platform/dell/dell-smbios-base.c
> @@ -390,6 +390,28 @@ bool dell_smbios_class_is_supported(u16 class)
> }
> EXPORT_SYMBOL_GPL(dell_smbios_class_is_supported);
>
> +/*
> + * Some Dell firmware completes its proprietary SMBIOS calls with all zeroes,
> + * so any value read through it (tokens, battery and thermal modes)
> + * is invalid.
> + */
> +static const struct dmi_system_id dell_smbios_calls_broken_list[] = {
> + {
> + .ident = "Dell XPS 16 DX16263",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 16 DX16263"),
> + },
> + },
> + { }
> +};
> +
> +bool dell_smbios_calls_functional(void)
> +{
> + return !dmi_check_system(dell_smbios_calls_broken_list);
> +}
> +EXPORT_SYMBOL_GPL(dell_smbios_calls_functional);
> +
> static void __init parse_da_table(const struct dmi_header *dm)
> {
> /* Final token is a terminator, so we don't want to copy it */
> diff --git a/drivers/platform/dell/dell-smbios.h b/drivers/platform/dell/dell-smbios.h
> index 1e64803bc00d..26f54364ffde 100644
> --- a/drivers/platform/dell/dell-smbios.h
> +++ b/drivers/platform/dell/dell-smbios.h
> @@ -89,6 +89,7 @@ int dell_laptop_register_notifier(struct notifier_block *nb);
> int dell_laptop_unregister_notifier(struct notifier_block *nb);
> void dell_laptop_call_notifier(unsigned long action, void *data);
> bool dell_smbios_class_is_supported(u16 class);
> +bool dell_smbios_calls_functional(void);
>
> /* for the supported backends */
> #ifdef CONFIG_DELL_SMBIOS_WMI
> --
> 2.53.0
>