Re: [PATCH v4 8/8] mm: zswap: Batched zswap_compress() for storing large folios in batches.
From: Nhat Pham
Date: Fri Nov 20 2026 - 18:55:22 EST
On Thu, Nov 19, 2026 at 8:19 PM Kanchana P. Sridhar
<kanchanapsridhar2026@xxxxxxxxx> wrote:
>
> A new batching implementation of zswap_compress() is provided for
> compressors that do and do not support batching. This eliminates code
> duplication and facilitates code maintainability with the introduction
> of compress batching.
>
> The vectorized implementation of calling the earlier zswap_compress()
> sequentially, one page at a time in zswap_store_pages(), is replaced
> with this new version of zswap_compress() that accepts multiple pages to
> compress as a batch.
>
> When the crypto_acomp is used to set up the per-CPU acomp_ctx
> during CPU onlining, the compressor's batch_size is obtained by calling:
>
> crypto_acomp_batch_size(acomp_ctx->acomp)
>
> This is bounded by ZSWAP_MAX_BATCH_SIZE to limit the memory
> overhead and to reflect the store batch constraint of max # of pages in
> a batch. The clamped batch_size is stored in the per-CPU
> acomp_ctx->comp.compr_batch_size.
>
> As noted in previous commits in this series, ZSWAP_MAX_BATCH_SIZE
> per-CPU compression buffers are available for sequential and batching
> compression algorithms.
>
> Regardless of compression batching, we always process large folios in
> batches of ZSWAP_MAX_BATCH_SIZE.
>
> If the compressor does not support batching, each page in the batch is
> compressed sequentially. For batching compressors, up to
> acomp_ctx->comp.compr_batch_size pages in the batch are compressed per
> call to crypto_acomp_compress(). The first phase of zswap_compress()
> thus only calls crypto_acomp_compress() until all pages in the batch
> have been compressed. When this finishes, the compressed buffers and
> compressed lengths for the batch are available in the
> acomp_ctx->comp.sg_table->sgl scatterlists.
>
> A new zswap_update_entries() then iterates through the (up to)
> ZSWAP_MAX_BATCH_SIZE SG lists in acomp_ctx->comp.sg_table->sgl,
> allocates zsmalloc memory and copies all compressed buffers to
> the compressed pool. All existing functionality on zswap
> writeback_enabled (or not) fallbacks under various error conditions
> denoted by the crypto_acomp_compress() return value [and with this
> commit, also stored in the individual acomp_ctx->comp.sg_table->sgl
> sg->lengths in the crypto_acomp_compress() fast path], is essentially
> preserved.
>
> A significant zswap architectural change is that the batched
> zswap_compress() incorporates Herbert's suggestion for SG lists to
> represent the batch's inputs/outputs to interface with the crypto API
> [1].
>
> The introduction of zswap_update_entries() presents an opportunity to
> optimize the task of storing a batch of compressed buffers. Subsequent
> patch series will be submitted to optimize this phase by replacing
> zsmalloc with the SLUB allocator to improve zswap_store()/zswap_load()
> latencies.
>
> The batching framework introduced in this series improves zswap_store()
> latency by a lot.
>
> Performance testing: usemem30 with 100% over-commit:
> =====================================================
> Validation was done with mm-unstable as of 11-17-2026 (Baseline: commit
> 866f761fd414) and with this patch series.
>
> v4 was validated on an Intel Xeon Sapphire Rapids bare-metal instance with
> 48 cores.
>
> Bare-metal instance specs:
> --------------------------
> - 48 physical cores
> - 190G RAM
> - 200G SWAP disk partition
>
> Workload: 30 concurrent usemem processes, each allocates 10G:
> -------------------------------------------------------------
> The vm-scalability "usemem" test (unmodified version) was run in a
> cgroup with memory.high fixed at 150G. There is no swap limit set for the
> cgroup.
>
> To quantify the performance benefit of zswap compress batching at scale,
> 30 usemem processes were run ("usemem30"), each allocating and writing 10G of
> memory, and sleeping for 10 sec before exiting.
>
> usemem -w -O -b 5 -s 10 -n 30 10g
> echo 0 > /sys/module/zswap/parameters/shrinker_enabled
>
> Performance validation methodology:
> -----------------------------------
> These settings were used to minimize variation:
>
> - All cores were fixed to run at 2.4GHz with "performance" scaling governor.
> - Turbo boost was disabled.
> - CPU power-saving C-states restricted with:
>
> GRUB_CMDLINE_LINUX_DEFAULT="intel_idle.max_cstate=1 processor.max_cstate=1"
>
> The usemem30 experiments were run with the baseline mm-unstable as of
> 11-17-2026 (commit 866f761fd414) and with this patch-series.
>
> After booting into each kernel:
>
> 1) Constrain the cgroup's memory.high to 150G.
>
> 2) Run 2 warm-up iterations of usemem30. Don't use this data for benchmarking
> since sys time typically skews higher for initial runs.
>
> 3) Next, run 10 benchmarking iterations of usemem30:
> - Log these high-level metrics: Sys time and individual usemem throughput.
>
> 4) Sys time and Throughput metrics were gathered for three mTHP settings:
>
> - 2048kB
> - 1024kB
> - 64kB
>
> 5) Benchmark summary data includes Sys time and Throughput components from the
> 10 iterations of usemem30:
>
> - Total Samples
> - Mean Value
> - Std Deviation
> - CoV (Variance): Coefficient of variation (relative standard
> deviation) measures spread relative to the mean rather than
> statistical variance.
>
> An LLM was used to help generate the benchmarking and data processing scripts.
>
> usemem30 Benchmarking Summary:
> ==============================
>
> ---------------------------------------------------
> Improvement with v4 zswap compress batching
> ---------------------------------------------------
> mTHP enabled: 2048kB 1024kB 64kB
> ---------------------------------------------------
> Sys time: -13.87% -2.64% -1.72%
> Throughput: +3.85% +0.42% +1.31%
> ---------------------------------------------------
>
> Detailed usemem30 benchmarking data:
> ====================================
>
> 1) 2048kB mTHP:
> ===============
>
> ------------------------------------------------------------------
> 2048kB mTHP usemem30 benchmark suite: 10 runs (Limit: 150G).
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (sec) (sec)
> ------------------------------------------------------------------
> [Run 1/10] Sys Time: 1581.414s 1356.252s
> [Run 2/10] Sys Time: 1642.874s 1478.929s
> [Run 3/10] Sys Time: 1594.458s 1411.252s
> [Run 4/10] Sys Time: 1580.988s 1380.959s
> [Run 5/10] Sys Time: 1579.654s 1380.609s
> [Run 6/10] Sys Time: 1627.765s 1345.582s
> [Run 7/10] Sys Time: 1593.872s 1334.485s
> [Run 8/10] Sys Time: 1623.189s 1405.471s
> [Run 9/10] Sys Time: 1661.954s 1433.365s
> [Run 10/10] Sys Time: 1602.098s 1329.813s
> ------------------------------------------------------------------
>
> ------------------------------------------------------------------
> METRIC: System CPU Time (Sys Time) : 2048kB mTHP
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (sec) (sec)
> ------------------------------------------------------------------
> Total Samples : 10 10
> Mean Value : 1,608.83 1,385.67
> Std Deviation : 28.67 47.47
> CoV (Variance) : 1.78% 3.43%
> ------------------------------------------------------------------
> METRIC: Per-Process Throughput : 2048kB mTHP
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (KB/s) (KB/s)
> ------------------------------------------------------------------
> Total Samples : 300 300
> Mean Value : 292,261 303,508
> Std Deviation : 12,946 20,806
> CoV (Variance) : 4.42% 6.86%
> ------------------------------------------------------------------
>
> 2) 1024kB mTHP:
> ===============
>
> ------------------------------------------------------------------
> 1024kB mTHP usemem30 benchmark suite: 10 runs (Limit: 150G).
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (sec) (sec)
> ------------------------------------------------------------------
> [Run 1/10] Sys Time: 1567.639s 1594.696s
> [Run 2/10] Sys Time: 1537.577s 1456.113s
> [Run 3/10] Sys Time: 1538.562s 1521.887s
> [Run 4/10] Sys Time: 1626.176s 1531.962s
> [Run 5/10] Sys Time: 1593.955s 1528.733s
> [Run 6/10] Sys Time: 1643.519s 1558.482s
> [Run 7/10] Sys Time: 1510.613s 1480.177s
> [Run 8/10] Sys Time: 1632.018s 1584.093s
> [Run 9/10] Sys Time: 1569.424s 1528.915s
> [Run 10/10] Sys Time: 1552.747s 1570.451s
> ------------------------------------------------------------------
>
> ------------------------------------------------------------------
> METRIC: System CPU Time (Sys Time) : 1024kB mTHP
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (sec) (sec)
> ------------------------------------------------------------------
> Total Samples : 10 10
> Mean Value : 1,577.22 1,535.55
> Std Deviation : 45.13 43.79
> CoV (Variance) : 2.86% 2.85%
> ------------------------------------------------------------------
> METRIC: Per-Process Throughput : 1024kB mTHP
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (KB/s) (KB/s)
> ------------------------------------------------------------------
> Total Samples : 300 300
> Mean Value : 289,904 291,114
> Std Deviation : 15,385 14,553
> CoV (Variance) : 5.31% 5.00%
> ------------------------------------------------------------------
>
> 3) 64kB mTHP:
> =============
>
> ------------------------------------------------------------------
> 64kB mTHP usemem30 benchmark suite: 10 runs (Limit: 150G).
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (sec) (sec)
> ------------------------------------------------------------------
> [Run 1/10] Sys Time: 1914.525s 1878.483s
> [Run 2/10] Sys Time: 1869.412s 1863.177s
> [Run 3/10] Sys Time: 1944.049s 1863.502s
> [Run 4/10] Sys Time: 1942.757s 1900.144s
> [Run 5/10] Sys Time: 1866.505s 1887.285s
> [Run 6/10] Sys Time: 1877.716s 1861.668s
> [Run 7/10] Sys Time: 1861.741s 1868.788s
> [Run 8/10] Sys Time: 1904.735s 1816.372s
> [Run 9/10] Sys Time: 1891.074s 1850.435s
> [Run 10/10] Sys Time: 1893.366s 1849.747s
> ------------------------------------------------------------------
>
> ------------------------------------------------------------------
> METRIC: System CPU Time (Sys Time) : 64kB mTHP
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (sec) (sec)
> ------------------------------------------------------------------
> Total Samples : 10 10
> Mean Value : 1,896.59 1,863.96
> Std Deviation : 29.86 22.96
> CoV (Variance) : 1.57% 1.23%
> ------------------------------------------------------------------
> METRIC: Per-Process Throughput : 64kB mTHP
> ------------------------------------------------------------------
> Baseline mm-unstable v4 zswap compress batching
> (KB/s) (KB/s)
> ------------------------------------------------------------------
> Total Samples : 300 300
> Mean Value : 239,114 242,254
> Std Deviation : 9,090 6,419
> CoV (Variance) : 3.80% 2.65%
> ------------------------------------------------------------------
The numbers look nice, but what's the zswap setup here? What's the
compressor? And how much of the win comes from this patch v.s the last
patch?
This patch series, and this patch in particular, seem like a lot of
complexity. I'd like to understand better the win before adding all
this complexity to the codebase.