Re: [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks

From: netdev-bot+sashiko

Date: Fri Nov 20 2026 - 16:18:04 EST


Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message says the patch keeps the OEM entries "in the
vendor table's alphabetical order", but the resulting sfp_quirks[]…
- [Low] After the reordering, the comment "// HORACO HC-10GE-113C uses
Rollball protocol to talk to the PHY." (sfp.c:620) heads a block with…

--

net: sfp: sort OEM and Turris SFP quirks

This commit reorders the sfp_quirks[] table in drivers/net/phy/sfp.c. It
moves the UBNT, Walsun and YV entries to after the OEM block, and sorts
the OEM and Turris entries by part number. No quirk matches or fixups are
changed.

> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index 960ac89cc2a0b..33349c3556b31 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -617,33 +617,24 @@ static const struct sfp_quirk sfp_quirks[] = {
> // ODI DFP-34X-2C3 XPON stick can operate at 2500base-X
> SFP_QUIRK_S("ODI", "DFP-34X-2C3", sfp_quirk_2500basex),
>
> - SFP_QUIRK_S("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant),
> -
> - // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the
> - // Rollball protocol to talk to the PHY.
> - SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt),
> - SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt),
> -
> - SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron),
> -
> // HORACO HC-10GE-113C uses Rollball protocol to talk to the PHY.
> SFP_QUIRK_F("OEM", "HC-10GE-113C", sfp_fixup_rollball),
> + SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
> + SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),

[Severity: Low]
Should there be a blank line after the HC-10GE-113C entry?

In the rest of sfp_quirks[], a comment applies to every entry up to the
next blank line. The Walsun, Fiberstore SFP-2.5G-T/SFP-10GM-T and Lantech
comments each cover two entries this way.

Because RTSFP-10 and RTSFP-10G now sit directly under it, the HORACO
comment reads as if it also describes those modules. They are different
modules, and they use sfp_fixup_rollball_cc, not sfp_fixup_rollball.

Before this patch, the HORACO comment covered one entry and was followed
by a blank line. The RTSFP entries were in the uncommented SFP-10G-T /
SFP-2.5G-* block. Could a blank line or a separate comment be added for
the RTSFP entries?

[ ... ]

> @@ -652,11 +643,20 @@ static const struct sfp_quirk sfp_quirks[] = {
> // match the part as a prefix.
> SFP_QUIRK_F_PREFIX("OEM", "XGSPONST2001", sfp_fixup_potron),
>
> + SFP_QUIRK_S("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant),
> +
> + // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the
> + // Rollball protocol to talk to the PHY.
> + SFP_QUIRK_F("Walsun", "HXSX-ATRC-1", sfp_fixup_fs_10gt),
> + SFP_QUIRK_F("Walsun", "HXSX-ATRI-1", sfp_fixup_fs_10gt),
> +
> + SFP_QUIRK_F("YV", "SFP+ONU-XGSPON", sfp_fixup_potron),
> +
> SFP_QUIRK_S("TP-LINK", "TL-SM410U", sfp_quirk_oem_2_5g),

[Severity: Low]
The commit message says:

Keep OEM entries together in the vendor table's alphabetical order

Is the vendor order alphabetical after this move? The UBNT, Walsun and YV
block now sits between OEM and TP-LINK, which gives this vendor order:

ODI, OEM, UBNT, Walsun, YV, TP-LINK, Turris, XikeStor, ZOERAX

In alphabetical order it would be:

ODI, OEM, TP-LINK, Turris, UBNT, Walsun, XikeStor, YV, ZOERAX

These are the only lines that this patch moves between vendors, and they
are still out of order. Would it make sense to put UBNT and Walsun after
Turris, and YV after XikeStor? Then a later patch would not need to move
the same lines again.

--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118162323.436219-1-github%40bumblecito.com