Re: [PATCH v2 1/2] mm/gup: add file_is_memfd_compatible() helper
From: Samiullah Khawaja
Date: Fri Nov 20 2026 - 15:04:06 EST
On Thu, Nov 19, 2026 at 04:35:31PM +0800, Jiahao Xu wrote:
memfd_pin_folios() accepts only shmem and file-hugetlb files and enforces
that inline with shmem_file() and is_file_hugepages(). A caller that has
to know up front whether a file may be handed to memfd_pin_folios()
cannot use those predicates: since d3710111839d ("mm/shmem: make
shmem_file() check the file's inode") shmem_file() is an out-of-line
function in mm/shmem.c which is not exported, so modules cannot call it,
and is_file_hugepages() on its own is not the same question.
Provide the check as an exported helper next to memfd_pin_folios() and
use it inside memfd_pin_folios() itself, so that a single place decides
which files may be pinned.
Signed-off-by: Jiahao Xu <xujiahao@xxxxxxxxxxxxxxxxxxxx>
---
v2:
- Rename memfd_pin_folios_supported() to file_is_memfd_compatible(),
suggested by David Hildenbrand: the predicate asks about the file, not
about the memfd interface.
v1: https://lore.kernel.org/all/20261119104417.312237-1-xujiahao@xxxxxxxxxxxxxxxxxxxx/
---
include/linux/mm.h | 1 +
mm/gup.c | 23 ++++++++++++++++++++++-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 040cff643..dffcc0b5a 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -3600,6 +3600,7 @@ long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages,
long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end,
struct folio **folios, unsigned int max_folios,
pgoff_t *offset);
+bool file_is_memfd_compatible(struct file *file);
int folio_add_pins(struct folio *folio, unsigned int pins);
int get_user_pages_fast(unsigned long start, int nr_pages,
diff --git a/mm/gup.c b/mm/gup.c
index 7605da0e0..da8a2c29b 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -3449,6 +3449,27 @@ long pin_user_pages_unlocked(unsigned long start, unsigned long nr_pages,
}
EXPORT_SYMBOL(pin_user_pages_unlocked);
+/**
+ * file_is_memfd_compatible() - check if a file may be used with
+ * memfd_pin_folios()
+ * @file: the file to check
+ *
+ * memfd_pin_folios() only accepts files backed by shmem or by hugetlb.
+ * This is wider than "is a memfd": every shmem file matches, not only the
+ * unlinked ones memfd_create() produces, and file-hugetlb files are not
+ * memfds at all.
+ *
+ * Callers that have to validate a file before pinning it, or before taking
+ * a reference to it, can use this helper instead of duplicating the check.
+ *
+ * Return: true if @file may be passed to memfd_pin_folios().
+ */
+bool file_is_memfd_compatible(struct file *file)
+{
+ return shmem_file(file) || is_file_hugepages(file);
+}
+EXPORT_SYMBOL_GPL(file_is_memfd_compatible);
+
/**
* memfd_pin_folios() - pin folios associated with a memfd
* @memfd: the memfd whose folios are to be pinned
@@ -3493,7 +3514,7 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end,
if (!memfd)
return -EINVAL;
- if (!shmem_file(memfd) && !is_file_hugepages(memfd))
+ if (!file_is_memfd_compatible(memfd))
return -EINVAL;
if (end >= i_size_read(file_inode(memfd)))
--
2.43.0
Reviewed-by: Samiullah Khawaja <skhawaja@xxxxxxxxxx>