Re: [PATCH net-next v4 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan

From: Florian Fainelli

Date: Fri Nov 20 2026 - 14:05:00 EST


On 11/19/26 21:38, netdev-bot+sashiko@xxxxxxxxxx wrote:
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The -EIO/-ENODEV -> -ENODEV mapping in get_phy_c45_ids()
(drivers/net/phy/phy_device.c) applies to every caller, not only…

Agreed. The commit message now says that get_phy_c45_ids() is reached through get_phy_device(bus, addr, true) and phy_get_c45_ids(). It lists the effect on the other callers: of_mdio logs the missing device and registers the bus without it, sfp ends up with "no PHY detected" after the usual retries, and gpy_probe() now gets -ENODEV, which the driver core treats as a silent match rejection. This matches what C22 callers already get from get_phy_c22_id().

- [Low] The commit message gives the UniMAC MDIO block (MDIO_READ_FAIL)
as its example of a controller whose read_c45() reports an empty…

The commit message now says that mdio-bcm-unimac does not provide read_c45() yet and that it is enabled by "net: mdio: mdio-bcm-unimac: Add Clause 45 support" later in the series.

- [Low] The patch rewrites the kernel-doc of get_phy_c45_ids() (lines
826-828) and of the exported phy_get_c45_ids() (lines 1107-1109).

That call is intentionally left unmapped. It only runs once a device has
answered, and mapping a bus error there to -ENODEV would make a PHY that fails midway disappear silently instead of failing the probe. I chose the second option you suggested and reworded the kernel-doc of both get_phy_c45_ids() and phy_get_c45_ids() to say "or a negative error code from a failed bus access otherwise (usually -EIO)". The commit message also states that the vendor MMD presence check and the identifier reads are not mapped.

pw-bot: cr
--
Florian