[for-linus][PATCH 30/32] ring-buffer: Do not check si_mem_available() before deferred init completes
From: Steven Rostedt
Date: Fri Nov 20 2026 - 12:43:12 EST
From: Amit Machhiwal <amachhiw@xxxxxxxxxxxxx>
With CONFIG_DEFERRED_STRUCT_PAGE_INIT=y, only about one memory section
per node is initialized early in boot (16 MiB on powerpc). The rest is
initialized on demand by deferred_grow_zone() when an allocation would
otherwise fail, or later by page_alloc_init_late().
Until then NR_FREE_PAGES can be close to zero, because early allocations
(SLUB, vmalloc, ftrace records) use up the first section.
si_mem_available() is derived from NR_FREE_PAGES, so it under-reports.
__rb_allocate_pages() returns -ENOMEM when si_mem_available() is below
the requested size. This check wrongly fails the buffers allocated for
the boot CPU in early_trace_init() and for secondary CPUs in smp_init(),
both of which run before page_alloc_init_late(). The resulting boot log
shows:
ERROR: Failed to allocate trace buffer
ERROR: tracer: failed to allocate ring buffer!
Skip the check until SYSTEM_FREEING_INITMEM on
CONFIG_DEFERRED_STRUCT_PAGE_INIT kernels. The allocation itself still
fails if memory really is short.
This is the second half of the fix for the early boot crash reported on
ppc64le KVM guests. Commit b3b974008388 ("tracing: Do not initialize
tracefs work if tracing is disabled") stopped the NULL pointer
dereference in __find_event_file() that followed the failed allocation.
This patch fixes the allocation failure itself.
Cc: stable@xxxxxxxxxxxxxxx
Fixes: 2a872fa4e9c8 ("ring-buffer: Check if memory is available before allocation")
Link: https://patch.msgid.link/20261118183235.63310-1-amachhiw@xxxxxxxxxxxxx
Reported-by: Michal Suchánek <msuchanek@xxxxxxx>
Closes: https://lore.kernel.org/all/arYskzbiaNzBR9MD@xxxxxxxxxxxxxx/
Reviewed-by: Vincent Donnefort <vdonnefort@xxxxxxxxxx>
Signed-off-by: Amit Machhiwal <amachhiw@xxxxxxxxxxxxx>
Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
---
kernel/trace/ring_buffer.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 0a1c7f98159e..a5a0adc934fa 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -2468,8 +2468,17 @@ static int __rb_allocate_pages(struct ring_buffer_per_cpu *cpu_buffer,
* memory. It may not be accurate. But we don't care, we just want
* to prevent doing any allocation when it is obvious that it is
* not going to succeed.
+ *
+ * With CONFIG_DEFERRED_STRUCT_PAGE_INIT, si_mem_available()
+ * will reflect the actual available memory only after
+ * SYSTEM_FREEING_INITMEM.
*/
- i = si_mem_available();
+ if (IS_ENABLED(CONFIG_DEFERRED_STRUCT_PAGE_INIT) &&
+ unlikely(system_state < SYSTEM_FREEING_INITMEM))
+ i = LONG_MAX;
+ else
+ i = si_mem_available();
+
if (i < (nr_pages << subbuf_order))
return -ENOMEM;
--
2.53.0