[for-linus][PATCH 28/32] tracing: Take trace_access_lock() in tracing_buffers_ioctl()
From: Steven Rostedt
Date: Fri Nov 20 2026 - 12:43:02 EST
From: Vincent Donnefort <vdonnefort@xxxxxxxxxx>
tracing_buffers_ioctl() calls ring_buffer_map_get_reader() without
trace_access_lock, breaking concurrent readers. Take trace_access_lock()
around ring_buffer_map_get_reader(), matching the other consuming
readers.
Cc: stable@xxxxxxxxxxxxxxx
Fixes: cf9f0f7c4c5b ("tracing: Allow user-space mapping of the ring-buffer")
Reported-by: Kyuwon Cho <kyuwoncho18@xxxxxxxxx>
Closes: https://lore.kernel.org/all/179485165154.2547186.6129837870360499372@xxxxxxxxx/
Link: https://patch.msgid.link/20261117082932.3441173-1-vdonnefort@xxxxxxxxxx
Signed-off-by: Vincent Donnefort <vdonnefort@xxxxxxxxxx>
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
---
kernel/trace/trace.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 70b3c11ac166..65b9d67647e5 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -7415,8 +7415,12 @@ static long tracing_buffers_ioctl(struct file *file, unsigned int cmd, unsigned
return err;
}
- return ring_buffer_map_get_reader(iter->array_buffer->buffer,
- iter->cpu_file);
+ trace_access_lock(iter->cpu_file);
+ err = ring_buffer_map_get_reader(iter->array_buffer->buffer,
+ iter->cpu_file);
+ trace_access_unlock(iter->cpu_file);
+
+ return err;
} else if (cmd) {
return -ENOTTY;
}
--
2.53.0