Re: [PATCH RESEND] block: pin user PI pages for writing when ref tags are remapped
From: Christoph Hellwig
Date: Fri Nov 20 2026 - 12:13:57 EST
On Fri, Nov 20, 2026 at 09:58:32AM -0700, Keith Busch wrote:
> > Agreed. I'll keep the PI iterator as ITER_SOURCE. In v2,
> > bio_integrity_map_user() will bounce the user PI buffer for REQ_OP_WRITE
> > when the integrity profile has BLK_INTEGRITY_REF_TAG. That way the
> > block layer can remap the tags in its own copy.
>
> Can avoid bouncing? I think the remapping flags can be tied to the
> user's reftag check request.
>
> If BIP_CHECK_REFTAG is set from the user setting IO_INTEGRITY_CHK_REFTAG
> on a write, we can map the PI buffer for writing. The user explicitly
> asked to have the ref tags checked by the device, and partitions require
> remapping them, so they've told the kernel to write to their buffer.
No, the user did not ask for violating the mapping direction. The
whole remapping thing very much is an internal implementation detail.
We could fine tune based on if we need remapping due to partitions,
if we limited remapping to partitions, but I think Martin last time
voiced an opinion that remapping could also be used to pass in
arbitrary tags (which always felt a bit odd to me).