Re: [PATCH rtw-next v3 3/5] wifi: rtw88: do not drop stations when collecting them for an iteration
From: Mehmet Fide
Date: Fri Nov 20 2026 - 12:03:16 EST
Hi Luka,
> Does the driver mutex still pin a client that has already gone back
> from ASSOC to AUTH?
No. I reproduced it with a small netlink tool that clears ASSOCIATED,
which hostapd never does: rtw_sta_remove() ran, the watchdog still
collected the client, and deleting it while a test build held the
collection freed it in mac80211 without a second rtw_sta_remove().
> Could we skip stations with no si->vif while collecting them? As far as
> I can see, rtw_sta_remove() clears it under the same mutex.
rtw_sta_remove() does not clear it today, si->vif is only set in
rtw_sta_add(). The client above was collected with si->vif still set.
v4 clears it in rtw_sta_remove() and skips such stations in
rtw_collect_sta_iter(). That also stops a firmware recovery from
calling rtw_sta_remove() a second time for such a client.
Mehmet