Re: [PATCH net-next V2 00/13] net/mlx5e: Add netdev support for data direct
From: Mina Almasry
Date: Fri Nov 20 2026 - 11:39:25 EST
On Fri, Nov 20, 2026 at 6:39 AM Dragos Tatulea <dtatulea@xxxxxxxxxx> wrote:
>
> Hi all,
>
> On 10.11.26 19:38, Tariq Toukan wrote:
> [...]
> >
> > .../ethernet/mellanox/mlx5/core/data_direct.c | 9 +-
> > drivers/net/ethernet/mellanox/mlx5/core/en.h | 14 +
> > .../ethernet/mellanox/mlx5/core/en/params.c | 18 +-
> > .../ethernet/mellanox/mlx5/core/en/params.h | 2 +
> > .../mellanox/mlx5/core/en/reporter_rx.c | 1 +
> > .../mellanox/mlx5/core/en/reporter_tx.c | 1 +
> > .../ethernet/mellanox/mlx5/core/en_common.c | 38 ++-
> > .../ethernet/mellanox/mlx5/core/en_ethtool.c | 67 +++++
> > .../net/ethernet/mellanox/mlx5/core/en_main.c | 253 +++++++++++++++++-
> > .../net/ethernet/mellanox/mlx5/core/en_rx.c | 33 +--
> > .../net/ethernet/mellanox/mlx5/core/en_tx.c | 4 +-
> > .../net/ethernet/mellanox/mlx5/core/main.c | 1 +
> > include/linux/mlx5/driver.h | 1 +
> > include/net/netdev_queues.h | 1 +
> > include/net/netmem.h | 24 ++
> > net/core/devmem.c | 85 ++++++
> > net/core/devmem.h | 6 +
> > net/core/netdev_queues.c | 51 ++++
> While working on V3 I realized that keeping the core part in
> this series is not the best approach. Initially it made sense
> because the change was small.
>
> I think I should re-spin it in a separate series with netdevsim
> based selftests for the new APIs. I would base it on Mina's devmem
> leased queues unregister [1].
>
> Any reason not to?
>
I honestly wanted to comment that you should base it on the leased
queues series from me but didn't want to be annoying, especially
because I made you wait for the previous series.
My series creates binding->bind_dev, and binding->map_dev, and core
will (should) handle things correctly across both devices. This seems
perfect for you, because you have a bind device and a separate map
device and their lifetime is different.
--
Thanks,
Mina