Re: [PATCH v8 17/33] cgroup/cpuset: Refuse to take a deadline task out of its root domain
From: Mathieu Desnoyers
Date: Fri Nov 20 2026 - 08:51:50 EST
> Can dl_tasks_keep_without() here reject a valid partition recovery with
> PERR_DLTASK because the root domains have not been rebuilt yet?
Yes, by reading. The refusal is false: the child partition stays invalid
with PERR_DLTASK until its next update. No bandwidth is lost. A fix needs
the span of the root domain that the rebuild will make. I would rather
do it in a follow-up.
> Does dl_task_keeps_root_domain() mismatch cpuset_update_tasks_cpumask() when
> offline CPUs are present in top_cpuset?
Mostly not. The span is normally inside cpus_mask, and cpus_mask inside
the user mask. If the user mask has no active CPU of the new mask, the
span has none either, and the check refuses. Your case needs a root
domain that grew after the affinity was set. set_cpus_allowed_ptr() then
fails with EINVAL, and the task keeps its old mask.
cpuset_update_tasks_cpumask() ignores that error on v7.4-rc2 too.
The test of your last paragraph can only refuse more often, never less.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com