Re: [PATCH v2] pinctrl: imx: Use of_device_id match table for per-SoC data

From: Fabio Estevam

Date: Fri Nov 20 2026 - 07:13:24 EST


On Fri, Nov 20, 2026 at 7:46 AM <joy.zou@xxxxxxxxxxx> wrote:
>
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Replace the hardcoded of_machine_is_compatible() if-else chain and the
> static string allowlist with a proper of_device_id match table carrying
> per-SoC data via the .data field.
>
> This eliminates the static local variable anti-pattern for daisy_off
> (lazy-initialized, shared across instances) and adopts the idiomatic
> kernel of_machine_get_match_data() APIs.
>
> A new pinctrl_scmi_imx_data struct captures the daisy register offset
> for future extensibility when new SoCs may not use register-offset based
> daisy configuration.
>
> No functional changes.
>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> Signed-off-by: Joy Zou <joy.zou@xxxxxxx>

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>