Re: [PATCH net v4 2/2] selftests: netfilter: cover IPv6 FIB prefix suppression
From: netdev-bot+sashiko
Date: Fri Nov 20 2026 - 06:11:04 EST
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The new in-tree comment before the IPv6 prefix-suppression block
in tools/testing/selftests/net/netfilter/nft_fib.sh says "The router's…
--
selftests: netfilter: cover IPv6 FIB prefix suppression
This adds IPv6 checks to nft_fib.sh for suppress_prefixlength 0. They
verify that a default route is suppressed while a more-specific route is
retained, and that blackhole, unreachable and prohibit routes (including
a blackhole nexthop object) stay terminal. The checks run after the
existing default-table tests.
The commit message says:
> The router's logging RPF rules have already been removed by then,
> allowing neighbour discovery during intentionally different reverse-route
> states.
The same statement appears as a comment in the patch, covered inline
below.
> diff --git a/tools/testing/selftests/net/netfilter/nft_fib.sh b/tools/testing/selftests/net/netfilter/nft_fib.sh
> index 04544905c2164..25e13197f0578 100755
> --- a/tools/testing/selftests/net/netfilter/nft_fib.sh
> +++ b/tools/testing/selftests/net/netfilter/nft_fib.sh
[ ... ]
> @@ -845,6 +889,52 @@ test_fib_type "default table"
> ip netns exec "$nsrouter" nft delete table ip filter
> ip netns exec "$nsrouter" nft delete table ip6 filter
>
> +# Keep the earlier IPv6 checks on the path without custom rules.
> +# The router's logging RPF rules have already been removed here.
[Severity: Low]
Is this comment accurate? Earlier, the script calls
load_pbr_ruleset "$nsrouter", and that installs a logging RPF check in
table inet filter:
load_pbr_ruleset() {
...
table inet filter {
chain forward {
type filter hook forward priority raw;
fib saddr . iif oif gt 0 accept
log drop
}
}
...
}
Between that load and this block, the only deletions are
"nft delete table ip filter" and "nft delete table ip6 filter", after
each test_fib_type call. Table inet filter is not flushed until the
"flush ruleset" in load_ruleset_vrf().
The prerouting nft_rpfilter logging rules from load_ruleset() are gone
at this point, since the earlier "nft flush ruleset" removed them. The
forward-hook "log drop" chain is still loaded, though.
The new probes (ping to dead:1::1) and neighbour discovery are delivered
locally and never reach the forward hook, so the checks still pass.
Could the comment, and the matching sentence in the commit message, say
that it is the prerouting nft_rpfilter rules that have been removed,
rather than all of the router's logging RPF rules?
> +if ip -net "$nsrouter" -6 rule add pref 100 to dead:1::99 table 128 \
> + suppress_prefixlength 0; then
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261117110813.9894-2-leonard%40lausen.nl