Re: [PATCH v15 0/2] clk: scmi: fix the i.MX OEM spread spectrum configuration

From: Dario Binacchi

Date: Fri Nov 20 2026 - 06:06:11 EST


Hi Brian,

Cristian has reviewed both patches [1][2]. Is that enough on the SCMI
side for you to pick them up, or would you rather wait for Sudeep?

Patch 1/2 is a fix for 7.3 (Cc: stable), so it could go in as a 7.4-rc fix.

Cristian, your reply to 2/2 [2] has a "From:" line where I think you
meant Reviewed-by. Could you confirm?

[1] https://lore.kernel.org/all/avMog5kzJpsiUhXn@pluto/
[2] https://lore.kernel.org/all/avMtgxmGXTbTKG1t@pluto/

Thanks and regards,
Dario

On Wed, Nov 4, 2026 at 11:36 AM Dario Binacchi
<dario.binacchi@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> These are the two patches of the v14 series [1] still pending, as
> patches 2/4 and 4/4 have been merged in 7.4-rc1.
>
> The first one is a fix for 7.3: the i.MX SCMI OEM extension converts
> the spread to the wrong unit, so the hardware is programmed with no
> spread at all for any valid configuration. The second one rejects the
> configurations that do not fit in the OEM fields, instead of silently
> truncating them.
>
> Brian is waiting for an ack from the SCMI side on both patches.
> Sudeep and the arm-scmi list were not Cc'ed on v14, as
> get_maintainer.pl does not list them for clk-scmi-oem.c.
>
> [1] https://lore.kernel.org/all/20260904101243.412006-1-dario.binacchi@xxxxxxxxxxxxxxxxxxxx/
>
> Changes in v15:
> - Drop patches 2/4 and 4/4, merged in 7.4-rc1.
> - Rebase on v7.4-rc1.
>
> Changes in v14:
> - Move the fixes first, so that they can be picked up separately from
> the new patches.
>
> Changes in v13:
> - Add patch "clk: scmi: reject SSC configuration out of the OEM field
> range".
> - Rename patch "clk: scmi: fix SSC permyriad conversion" to "clk: scmi:
> fix SSC spread conversion".
>
> Changes in v12:
> - Add patch "clk: scmi: fix SSC permyriad conversion" to fix the
> permyriad to percent conversion in clk-scmi-oem.c, reported by
> Sashiko AI review.
>
> Changes in v11:
> - Add patch "clk: Validate spread spectrum configuration" to reject
> invalid parameters in the clk core before they reach the providers.
>
> Changes in v10:
> - Drop patches 1-22, superseded by the generic spread spectrum clocking
> support from Peng Fan, merged in 7.3, so the i.MX8M specific infrastructure
> is no longer needed. This patch is now based on the following commits:
> - ae794aa6e88d ("dt-bindings: clock: Add spread spectrum definition")
> - c86814e70390 ("clk: Introduce clk_hw_set_spread_spectrum")
> - a7f16660af39 ("clk: conf: Support assigned-clock-sscs")
> - 7d98de6ffdab ("clk: Add KUnit tests for assigned-clock-sscs")
> https://lore.kernel.org/all/20260826165611.236321-1-sboyd@xxxxxxxxxx/
>
> Changes in v9:
> - Add 'Reviewed-by' tag of Peng Fan for imx8mn platform patches
> - Fix building warning raised by the kernel test robot for patch
> v8, 11/18 clk: imx: add support for i.MX8MN anatop clock driver
> - Add patches for imx8m{m,p} platforms:
> - 23/23 clk: imx8mm: support spread spectrum clock generation
> - 22/23 clk: imx: add support for i.MX8MM anatop clock driver
> - 21/23 clk: imx8mp: support spread spectrum clock generation
> - 20/23 clk: imx8mp: rename ccm_base to base
> - 19/23 clk: imx: add support for i.MX8MP anatop clock driver
>
> Changes in v8:
> - Drop the patches added in version 7:
> - 10/23 dt-bindings: clock: imx8m-clock: add phandle to the anatop
> - 11/23 arm64: dts: imx8mm: add phandle to anatop within CCM
> - 12/23 arm64: dts: imx8mn: add phandle to anatop within CCM
> - 13/23 arm64: dts: imx8mp: add phandle to anatop within CCM
> - 14/23 arm64: dts: imx8mq: add phandle to anatop within CCM
>
> Changes in v7:
> - Add and manage fsl,anatop property as phandle to the anatop node with
> the new patches:
> - 10/23 dt-bindings: clock: imx8m-clock: add phandle to the anatop
> - 11/23 arm64: dts: imx8mm: add phandle to anatop within CCM
> - 12/23 arm64: dts: imx8mn: add phandle to anatop within CCM
> - 13/23 arm64: dts: imx8mp: add phandle to anatop within CCM
> - 14/23 arm64: dts: imx8mq: add phandle to anatop within CCM
>
> Changes in v6:
> - Merge patches:
> 10/20 dt-bindings: clock: imx8mm: add binding definitions for anatop
> 11/20 dt-bindings: clock: imx8mn: add binding definitions for anatop
> 12/20 dt-bindings: clock: imx8mp: add binding definitions for anatop
> to
> 05/20 dt-bindings: clock: imx8m-anatop: define clocks/clock-names
> now renamed
> 05/18 dt-bindings: clock: imx8m-anatop: add oscillators and PLLs
> - Split the patch
> 15/20 dt-bindings-clock-imx8m-clock-support-spread-spectru.patch
> into
> 12/18 dt-bindings: clock: imx8m-clock: add PLLs
> 16/18 dt-bindings: clock: imx8m-clock: support spread spectrum clocking
>
> Changes in v5:
> - Fix compilation errors.
> - Separate driver code from dt-bindings
>
> Changes in v4:
> - Add dt-bindings for anatop
> - Add anatop driver
> - Drop fsl,ssc-clocks from spread spectrum dt-bindings
>
> Changes in v3:
> - Patches 1/8 has been added in version 3. The dt-bindings have
> been moved from fsl,imx8m-anatop.yaml to imx8m-clock.yaml. The
> anatop device (fsl,imx8m-anatop.yaml) is indeed more or less a
> syscon, so it represents a memory area accessible by ccm
> (imx8m-clock.yaml) to setup the PLLs.
> - Patches {3,5}/8 have been added in version 3.
> - Patches {4,6,8}/8 use ccm device node instead of the anatop one.
>
> Changes in v2:
> - Add "allOf:" and place it after "required:" block, like in the
> example schema.
> - Move the properties definition to the top-level.
> - Drop unit types as requested by the "make dt_binding_check" command.
>
> Dario Binacchi (2):
> clk: scmi: fix SSC spread conversion
> clk: scmi: reject SSC configuration out of the OEM field range
>
> drivers/clk/clk-scmi-oem.c | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> ---
> base-commit: 05441d697f7f9a927264f4058cbbc6a03dfcac9d
> branch: imx-pll14xx-spread-spectrum
>
> --
> 2.43.0
>


--
Dario Binacchi
Senior Embedded Software Engineer
M. +39 328 0625246
dario.binacchi@xxxxxxxxxxxxxxxxxxxx
―――――――――――――――
Amarula Solutions SRL
Via Felice Cavallotti 25D, 41012 Carpi, MO, IT
info@xxxxxxxxxxxxxxxxxxxx
www.amarulasolutions.com