Re: [PATCH] usb: gadget: f_fs: fix use-after-free on umount

From: Greg KH

Date: Fri Nov 20 2026 - 05:17:45 EST


On Thu, Oct 08, 2026 at 02:39:55AM +0200, Eduard Zateev wrote:
> ffs_free_inst() releases a device and drops ffs_dev_lock before it
> removes and frees the device. A concurrent FunctionFS mount can find
> the released device in that window, attach a new ffs_data to it, and
> then use the freed device from ffs_closed() during unmount.
>
> Keep ffs_dev_lock held across release and free so a new mount cannot
> attach to a device being torn down. In ffs_data_put(), read
> ffs->private_data only after acquiring the same lock, since a concurrent
> ffs_free_inst() may clear and free the referenced device while the
> putter waits for the lock.
>
> Fixes: ecfbd7b9054b ("usb: gadget: f_fs: Fix setting of device and driver data cross-references")
>
> Reported-by: syzbot+6227549bd2c8a1ec8ba0@xxxxxxxxxxxxxxxxxxxxxxxxx
>
> Link: https://syzkaller.appspot.com/bug?extid=6227549bd2c8a1ec8ba0

No blank lines between these different tags, right?

thanks,

greg k-h