Re: [PATCH] rust: drm: remove DRM device private data
From: Alice Ryhl
Date: Fri Nov 20 2026 - 04:53:58 EST
On Thu, Nov 19, 2026 at 06:28:07PM +0100, Danilo Krummrich wrote:
> On Thu Nov 19, 2026 at 12:49 PM CET, Alice Ryhl wrote:
> > Good idea
>
> Indeed, what do you think about this?
>
> diff --git a/rust/kernel/drm/device.rs b/rust/kernel/drm/device.rs
> index 774db3acb15a..8c48dcfdecec 100644
> --- a/rust/kernel/drm/device.rs
> +++ b/rust/kernel/drm/device.rs
> @@ -158,7 +158,11 @@ const fn compute_features() -> u32 {
> open: Some(drm::File::<T::File>::open_callback),
> postclose: Some(drm::File::<T::File>::postclose_callback),
> unload: None,
> - release: None,
> + release: {
> + // The DRM core frees the device without running a Rust destructor.
> + const_assert!(!mem::needs_drop::<Device<T, Normal>>());
> + None
> + },
> master_set: None,
> master_drop: None,
> debugfs_init: None,
Looks good to me.
Alice