RE: [PATCH v8 03/11] media: chips-media: wave6: Add Wave6 core driver
From: Nas Chung
Date: Fri Nov 20 2026 - 03:56:47 EST
Hi, Frank.
>-----Original Message-----
>From: Frank Li <Frank.li@xxxxxxxxxxx>
>Sent: Friday, November 20, 2026 5:28 AM
>To: Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
>Cc: mchehab@xxxxxxxxxx; hverkuil@xxxxxxxxxx; robh@xxxxxxxxxx;
>krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; Frank.Li@xxxxxxx;
>s.hauer@xxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx;
>devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>imx@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
>festevam@xxxxxxxxx; kernel@xxxxxxxxxxxxxx; nicolas.dufresne@xxxxxxxxxxxxx;
>ming.qian@xxxxxxxxxxx; marek.vasut@xxxxxxxxxxx; jackson.lee
><jackson.lee@xxxxxxxxxxxxxxx>; lafley.kim <lafley.kim@xxxxxxxxxxxxxxx>
>Subject: Re: [PATCH v8 03/11] media: chips-media: wave6: Add Wave6 core
>driver
>
>On Thu, Nov 19, 2026 at 05:59:57PM +0900, Nas Chung wrote:
>> Add the core driver for the Chips&Media Wave6 video codec IP.
>>
>> The hardware contains one control register region and four interface
>> register regions for a shared video processing engine. The core driver
>> handles the interface register regions, each with its own MMIO range
>> and interrupt, while relying on the control driver for firmware loading
>> and shared resource management.
>>
>> It configures the V4L2 mem2mem devices and communicates with the Wave6
>> hardware to perform video processing tasks.
>>
>> Tested-by: Ming Qian <ming.qian@xxxxxxxxxxx>
>> Tested-by: Marek Vasut <marek.vasut@xxxxxxxxxxx>
>> Signed-off-by: Nas Chung <nas.chung@xxxxxxxxxxxxxxx>
>> ---
>> .../media/platform/chips-media/wave6/Kconfig | 2 +
>> .../media/platform/chips-media/wave6/Makefile | 5 +-
>> .../platform/chips-media/wave6/wave6-hw.c | 181 ++++++++
>> .../platform/chips-media/wave6/wave6-hw.h | 22 +
>> .../chips-media/wave6/wave6-regdefine.h | 65 +++
>> .../platform/chips-media/wave6/wave6-vdi.h | 20 +
>> .../chips-media/wave6/wave6-vpu-core.c | 392 ++++++++++++++++++
>> .../chips-media/wave6/wave6-vpu-core.h | 106 +++++
>> .../chips-media/wave6/wave6-vpu-v4l2.c | 384 +++++++++++++++++
>> .../platform/chips-media/wave6/wave6-vpu.c | 24 +-
>> .../platform/chips-media/wave6/wave6-vpu.h | 2 +
>> .../platform/chips-media/wave6/wave6-vpuapi.h | 381 +++++++++++++++++
>> .../chips-media/wave6/wave6-vpuconfig.h | 6 +
>> 13 files changed, 1588 insertions(+), 2 deletions(-)
>> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-hw.c
>> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-hw.h
>> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-
>core.c
>> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-
>core.h
>> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-vpu-
>v4l2.c
>> create mode 100644 drivers/media/platform/chips-media/wave6/wave6-
>vpuapi.h
>>
>...
>> +
>> +u32 wave6_vpu_readl(struct vpu_core_device *core, u32 addr)
>> +{
>> + u32 data;
>> +
>> + data = wave6_vdi_readl(core->reg_base, addr);
>> +
>> + return data;
>
>return wave6_vdi_readl(core->reg_base, addr);
OK.
>
>> +}
>> +
>> +void wave6_vpu_writel_relaxed(struct vpu_core_device *core, u32 addr,
>u32 data)
>> +{
>> + wave6_vdi_writel_relaxed(core->reg_base, addr, data);
>> +}
>> +
>> +u32 wave6_vpu_readl_relaxed(struct vpu_core_device *core, u32 addr)
>> +{
>> + u32 data;
>> +
>> + data = wave6_vdi_readl_relaxed(core->reg_base, addr);
>
>return wave6_vdi_readl_relaxed(core->reg_base, addr);
OK.
>
>> +
>> + return data;
>> +}
>> +
>...
>> +static u32 wave6_vpu_get_product_id(struct vpu_core_device *core)
>> +{
>> + u32 val;
>> +
>> + lockdep_assert_held(&core->hw_lock);
>> +
>> + val = vpu_read_reg_relaxed(core, W6_VPU_RET_PRODUCT_CODE);
>> +
>> + switch (val) {
>> + case WAVE617_CODE:
>> + return PRODUCT_ID_617;
>> + case WAVE627_CODE:
>> + return PRODUCT_ID_627;
>> + case WAVE633_CODE:
>> + case WAVE637_CODE:
>> + case WAVE663_CODE:
>> + case WAVE677_CODE:
>> + return PRODUCT_ID_637;
>
>what is use for? why not direct use WAVE*_CODE?
It is unused. I'll remove enum product_id.
>
>> + default:
>> + dev_err(core->dev, "Invalid product (%x)\n", val);
>> + break;
>> + }
>> +
>> + return PRODUCT_ID_NONE;
>> +}
>> +
>...
>> +
>> +#endif /* __WAVE6_HW_H__ */
>> diff --git a/drivers/media/platform/chips-media/wave6/wave6-regdefine.h
>b/drivers/media/platform/chips-media/wave6/wave6-regdefine.h
>> index e879a9743cb3..aa9b972c82d1 100644
>> --- a/drivers/media/platform/chips-media/wave6/wave6-regdefine.h
>> +++ b/drivers/media/platform/chips-media/wave6/wave6-regdefine.h
>> @@ -14,14 +14,51 @@ enum wave6_command {
>> W6_CMD_INIT_VPU = 0x0001,
>> W6_CMD_WAKEUP_VPU = 0x0002,
>> W6_CMD_SLEEP_VPU = 0x0004,
>> + W6_CMD_CREATE_INSTANCE = 0x0008,
>> + W6_CMD_FLUSH_INSTANCE = 0x0010,
>> + W6_CMD_DESTROY_INSTANCE = 0x0020,
>> + W6_CMD_INIT_SEQ = 0x0040,
>> + W6_CMD_SET_FB = 0x0080,
>> + W6_CMD_DEC_PIC = 0x0100,
>> + W6_CMD_DEC_SET_DISP = 0x0400,
>
>BIT()?
OK.
>
>> W6_CMD_INIT_WORK_BUF = 0x1000,
>> + W6_CMD_QUERY = 0x4000,
>> +};
>> +
>...
>>
>> #endif /* __WAVE6_REGDEFINE_H__ */
>> diff --git a/drivers/media/platform/chips-media/wave6/wave6-vdi.h
>b/drivers/media/platform/chips-media/wave6/wave6-vdi.h
>> index 69ebf0ebcb13..67704fdbe27d 100644
>> --- a/drivers/media/platform/chips-media/wave6/wave6-vdi.h
>> +++ b/drivers/media/platform/chips-media/wave6/wave6-vdi.h
>> @@ -13,6 +13,26 @@
>> #include <linux/dma-mapping.h>
>> #include <linux/io.h>
>>
>> +enum endian_mode {
>
>name is too general and easy happen name collision.
I'll rename it to enum wave6_endian_mode.
>
>> + VDI_128BIT_BIG_ENDIAN = 0,
>> + VDI_128BIT_BE_BYTE_SWAP,
>> + VDI_128BIT_BE_WORD_SWAP,
>> + VDI_128BIT_BE_WORD_BYTE_SWAP,
>> + VDI_128BIT_BE_DWORD_SWAP,
>> + VDI_128BIT_BE_DWORD_BYTE_SWAP,
>> + VDI_128BIT_BE_DWORD_WORD_SWAP,
>> + VDI_128BIT_BE_DWORD_WORD_BYTE_SWAP,
>> + VDI_128BIT_LE_DWORD_WORD_BYTE_SWAP,
>> + VDI_128BIT_LE_DWORD_WORD_SWAP,
>> + VDI_128BIT_LE_DWORD_BYTE_SWAP,
>> + VDI_128BIT_LE_DWORD_SWAP,
>> + VDI_128BIT_LE_WORD_BYTE_SWAP,
>> + VDI_128BIT_LE_WORD_SWAP,
>> + VDI_128BIT_LE_BYTE_SWAP,
>> + VDI_128BIT_LITTLE_ENDIAN = 15,
>> + VDI_ENDIAN_MAX
>> +};
>> +
>> /**
>> * struct vpu_buf - VPU buffer for a coherent DMA buffer
>> * @size: Buffer size
>> diff --git a/drivers/media/platform/chips-media/wave6/wave6-vpu-core.c
>b/drivers/media/platform/chips-media/wave6/wave6-vpu-core.c
>> new file mode 100644
>> index 000000000000..67c6666579d9
>> --- /dev/null
>> +++ b/drivers/media/platform/chips-media/wave6/wave6-vpu-core.c
>> @@ -0,0 +1,392 @@
>> +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
>> +/*
>> + * Wave6 series multi-standard codec IP - wave6 core driver
>> + *
>> + * Copyright (C) 2026 CHIPS&MEDIA INC
>> + */
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/clk.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/iopoll.h>
>
>sort
OK.
>
>> +
>> +#include "wave6-vpu-core.h"
>> +#include "wave6-regdefine.h"
>> +#include "wave6-vpuconfig.h"
>> +#include "wave6-hw.h"
>> +
>> +static irqreturn_t wave6_vpu_core_irq(int irq, void *dev_id)
>> +{
>> + struct vpu_core_device *core = dev_id;
>> + struct vpu_irq irq_info;
>> +
>> + if (!vpu_read_reg(core, W6_VPU_VPU_INT_STS))
>> + return IRQ_NONE;
>> +
>> + irq_info.status = vpu_read_reg(core, W6_VPU_VINT_REASON);
>> + irq_info.inst_idc = vpu_read_reg(core, W6_RET_INT_INSTANCE_INFO);
>> +
>> + vpu_write_reg(core, W6_RET_INT_INSTANCE_INFO,
>INT_INSTANCE_INFO_CLEAR);
>
>suppose only already set irq, irq_info.inst_idc, like below code?
This is a plain register, not a write-1-to-clear one. The firmware
does not write the next instance bit until the driver clears
W6_VPU_VINT_REASON, and the driver clears this register first. So
writing 0 does not lose any bit.
>
>> + vpu_write_reg(core, W6_VPU_VINT_REASON_CLEAR, irq_info.status);
>> + vpu_write_reg(core, W6_VPU_VINT_CLEAR, VINT_CLEAR);
>> +
>> + if (irq_info.status & BIT(W6_INT_BIT_REQ_WORK_BUF)) {
>> + wave6_vpu_require_work_buffer(core->vpu, core->reg_base);
>> +
>> + return IRQ_HANDLED;
>> + }
>> +
>> + if (kfifo_in(&core->irq_fifo, &irq_info, sizeof(struct vpu_irq)) !=
>> + sizeof(struct vpu_irq))
>> + dev_err(core->dev, "IRQ overflow status 0x%x idc 0x%x\n",
>> + irq_info.status, irq_info.inst_idc);
>> +
>> + return IRQ_WAKE_THREAD;
>> +}
>> +
>> + core->irq = platform_get_irq(pdev, 0);
>
>...
>
>> + if (core->irq < 0)
>> + return core->irq;
>> +
>> + ret = devm_request_threaded_irq(&pdev->dev, core->irq,
>> + wave6_vpu_core_irq,
>> + wave6_vpu_core_irq_thread,
>> + 0, "vpu_irq", core);
>> + if (ret) {
>> + dev_err(&pdev->dev, "failed to request IRQ: %d\n", ret);
>> + return ret;
>
>return dev_err_probe();
OK.
>
>> + }
>> +
>> + ret = v4l2_device_register(&pdev->dev, &core->v4l2_dev);
>> + if (ret) {
>> + dev_err(&pdev->dev, "failed to register v4l2_dev: %d\n", ret);
>> + return ret;
>> + }
>> +
>...
>> +void wave6_vpu_writel(struct vpu_core_device *core, u32 addr, u32 data);
>> +void wave6_vpu_writel_relaxed(struct vpu_core_device *core, u32 addr,
>u32 data);
>> +u32 wave6_vpu_readl(struct vpu_core_device *core, u32 addr);
>> +u32 wave6_vpu_readl_relaxed(struct vpu_core_device *core, u32 addr);
>> +
>> +#endif /* __WAVE6_VPUAPI_H__ */
>> diff --git a/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h
>b/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h
>> index 1d4e016c2a58..fccb854a8a8c 100644
>> --- a/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h
>> +++ b/drivers/media/platform/chips-media/wave6/wave6-vpuconfig.h
>> @@ -18,13 +18,19 @@
>> #define W6_VPU_MAX_NUM_CORE 4
>> #define MAX_NUM_INSTANCE 32
>>
>> +#define W6_MAX_PIC_STRIDE (4096 * 4)
>> +#define W6_PIC_STRIDE_ALIGNMENT 32
>> +
>> #define W6_VPU_POLL_DELAY_US 10
>> #define W6_VPU_POLL_TIMEOUT 300000
>> +#define W6_BOOT_WAIT_TIMEOUT 10000
>> +#define W6_VPU_TIMEOUT 6000
>
>Need unit
I'll add _MS/_US suffixes.
Thanks.
Nas.
>
>Frank
>>
>> #define W6_MAX_REMAP_PAGE_SIZE (1024 * 1024)
>> #define W6_MAX_CODE_BUF_SIZE (4 * 1024 * 1024)
>> #define W6_CODE_BUF_SIZE (1 * 1024 * 1024)
>> #define W6_EXTRA_CODE_BUF_SIZE (256 * 1024)
>> +#define W6_TEMPBUF_SIZE (3 * 1024 * 1024)
>> #define W637DEC_WORKBUF_SIZE_FOR_CQ (3 * 512 * 1024)
>>
>> static inline bool wave6_is_product_w_series(u32 code)
>> --
>> 2.41.0.windows.3
>>
>>