Re: [PATCH v5 07/17] mm/mglru: make folio lru referenced times count a generic API
From: KunWu Chan
Date: Fri Nov 20 2026 - 03:18:03 EST
On Thu, Nov 19, 2026 at 5:03 AM Kairui Song via B4 Relay
<devnull+kasong.tencent.com@xxxxxxxxxx> wrote:
>
> From: Kairui Song <kasong@xxxxxxxxxxx>
>
> Pure code shuffle, no behavior change.
>
> Make the folio LRU refs helpers available regardless of CONFIG_LRU_GEN.
> Without MGLRU the extra bits are never set, so they are inert. Move the
> lru_gen_* helpers into the CONFIG_LRU_GEN section. This prepares for
> unifying the API for checking folio referenced and workingset status.
>
> folio_migrate_lru_refs() now migrates the complete refs count,
> including PG_workingset (bit 1 of the encoding), bitwise identical to
> the direct copy dropped from folio_migrate_flags().
>
> lru_set_refs_flags() skips the nonexistent mask bits when
> LRU_REFS_WIDTH collapses to 0, preserving the two independent flags for
> !CONFIG_LRU_GEN builds.
>
> Tested-by: Zhao Zhenzhuo <zhaozhengzhuo@xxxxxxxxxxxxx>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxxx>
> ---
> include/linux/mm_inline.h | 55 ++++++++++++++++++++++++-----------------------
> mm/migrate.c | 2 --
> 2 files changed, 28 insertions(+), 29 deletions(-)
>
> diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
> index f38dad1198fc..180db43c3a85 100644
> --- a/include/linux/mm_inline.h
> +++ b/include/linux/mm_inline.h
> @@ -184,6 +184,12 @@ static inline int lru_get_gen_flags(unsigned long flags)
> return gen;
> }
>
> +static inline int folio_lru_gen(const struct folio *folio)
> +{
> + return lru_get_gen_flags(READ_ONCE(*const_folio_flags(folio, 0)));
> +}
> +#endif
> +
> /**
> * lru_set_refs_flags - Set the LRU referenced count to folio flags.
> * @flags: pointer to the folio flags
> @@ -206,7 +212,8 @@ static inline void lru_set_refs_flags(unsigned long *flags, unsigned int refs)
> *flags |= BIT(PG_referenced);
> if (refs & BIT(1))
> *flags |= BIT(PG_workingset);
> - *flags |= ((unsigned long)refs >> 2) << LRU_REFS_PGOFF;
> + if (LRU_REFS_WIDTH)
> + *flags |= ((unsigned long)refs >> 2) << LRU_REFS_PGOFF;
> }
>
> /**
> @@ -252,13 +259,31 @@ static inline void folio_set_lru_refs(struct folio *folio, unsigned int refs)
> } while (!try_cmpxchg(folio_flags(folio, 0), &old_flags, new_flags));
> }
>
> +#ifdef CONFIG_LRU_GEN
> void folio_inc_lru_refs(struct folio *folio, unsigned int flags);
> +#else
> +static inline void folio_inc_lru_refs(struct folio *folio, unsigned int flags)
> +{
> + /* Should not be called with !CONFIG_LRU_GEN */
> + WARN_ON_ONCE(1);
> +}
> +#endif
>
> -static inline int folio_lru_gen(const struct folio *folio)
> +/**
> + * folio_migrate_lru_refs - copy the reference state to a new folio
> + * @new: the destination folio
> + * @old: the source folio
> + *
> + * Transfer the reference state to @new during migration: the MGLRU
> + * refs count, or PG_referenced and PG_workingset (bits 0-1 of the
> + * encoding) for the active/inactive LRU.
> + */
> +static inline void folio_migrate_lru_refs(struct folio *new, const struct folio *old)
> {
> - return lru_get_gen_flags(READ_ONCE(*const_folio_flags(folio, 0)));
> + folio_set_lru_refs(new, folio_lru_refs(old));
> }
>
> +#ifdef CONFIG_LRU_GEN
> static inline bool lru_gen_is_old(struct lruvec *lruvec, int type, int gen)
> {
> unsigned long min_seq = READ_ONCE(lruvec->lrugen.min_seq[type]);
> @@ -424,20 +449,6 @@ static inline bool lru_gen_del_folio(struct lruvec *lruvec, struct folio *folio,
>
> return true;
> }
> -
> -/**
> - * folio_migrate_lru_refs - copy the reference state to a new folio
> - * @new: the destination folio
> - * @old: the source folio
> - *
> - * Transfer the reference state to @new during migration: the MGLRU
> - * refs count, including PG_referenced, or just PG_referenced for the
> - * active/inactive LRU.
> - */
> -static inline void folio_migrate_lru_refs(struct folio *new, const struct folio *old)
> -{
> - folio_set_lru_refs(new, folio_lru_refs(old));
> -}
> #else /* !CONFIG_LRU_GEN */
>
> static inline bool lru_gen_enabled(void)
> @@ -470,16 +481,6 @@ static inline bool lru_gen_del_folio(struct lruvec *lruvec, struct folio *folio,
> {
> return false;
> }
> -
> -static inline void folio_inc_lru_refs(struct folio *folio, unsigned int flags)
> -{
> -}
> -
> -static inline void folio_migrate_lru_refs(struct folio *new, const struct folio *old)
> -{
> - if (folio_test_referenced(old))
> - folio_set_referenced(new);
> -}
> #endif /* CONFIG_LRU_GEN */
>
> static __always_inline
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 28a8d7734735..c8c49357df87 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -796,8 +796,6 @@ void folio_migrate_flags(struct folio *newfolio, struct folio *folio)
> folio_set_active(newfolio);
> } else if (folio_test_clear_unevictable(folio))
> folio_set_unevictable(newfolio);
> - if (folio_test_workingset(folio))
> - folio_set_workingset(newfolio);
> if (folio_test_checked(folio))
> folio_set_checked(newfolio);
> /*
>
> --
> 2.56.1
>
>
Reviewed-by: Kunwu Chan <kunwu.chan@xxxxxxxxx>
Thanks,
Kunwu