RE: [PATCH] wifi: rtlwifi: Fix octal 024 typo in P2P_PS_OFFLOAD H2C command IDs
From: Ping-Ke Shih
Date: Thu Nov 19 2026 - 19:33:57 EST
Ian Rogers <irogers@xxxxxxxxxx> wrote:
> In rtl8821ae, rtl8192ee, and rtl8188ee, the H2C power-save command enums
> define 0x20, 0x21, 0x22, 0x23 followed by 'H2C_*_P2P_PS_OFFLOAD = 024'.
> The missing 'x' makes 024 an octal constant (decimal 20, 0x14) instead of
> 0x24 (decimal 36, matching H2C_8723B_P2P_PS_OFFLOAD = 0x24 in rtl8723be
> and rtl8xxxu), sending the wrong H2C command ID to firmware during Wi-Fi
> Direct P2P power-save offload updates.
>
> Change 024 to 0x24 in all three headers.
>
> Found via inspection of H2C command enums during an x86_64 LLVM=1
> (Clang 21.1.8) allyesconfig warning audit; fix and changelog drafted with
> an AI coding assistant. Build-tested under LLVM=1 W=1 (-Werror); not
> tested on Realtek Wi-Fi hardware.
>
> Fixes: f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver")
> Fixes: 21e4b0726dc6 ("rtlwifi: rtl8821ae: Move driver from staging to regular tree")
> Fixes: b1a3bfc97cd9 ("rtlwifi: rtl8192ee: Move driver from staging to the regular tree")
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
Cross check with vendor driver. 0x24 is correct.
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>