Re: [PATCH net-next 3/4] eth: mpnic: sync unicast and multicast address lists
From: Jakub Kicinski
Date: Thu Nov 19 2026 - 19:15:41 EST
On Wed, 18 Nov 2026 05:21:44 -0500 Daniel Zahka wrote:
> > Would it make sense to flush stale entries from both lists before either
> > add phase runs?
> >
>
> I see this more as a low severity issue, because having the device be in
> promiscuous mode when a slot is free is not incorrect, just not optimal.
>
> If anything I would probably just rerun __hw_addr_sync_dev() on the uc
> list again after the mc one, if the first call returned -ENOSPC. I
> didn't think that was really worth it when this same comment came up in
> local review though.
Ack, IIRC the MAC table is at least 100 addrs, so micro-optimizing
the ~128 -> 127 transition isn't worth the LoC.