Re: [PATCH] bus: brcmstb_gisb: Check required IRQ lookup results
From: Florian Fainelli
Date: Thu Nov 19 2026 - 17:59:23 EST
On 11/14/26 06:22, Alex Guo wrote:
platform_get_irq() can return a negative error code for the timeout
or target abort interrupt. Passing it to devm_request_irq() can
replace the lookup error with -EINVAL.
Check both lookup results and return the original error before
requesting either interrupt.
A similar issue was fixed in commit 47c3e06ed95a
("spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe").
Fixes: 44127b771d9c ("bus: add Broadcom GISB bus arbiter timeout/error handler")
Signed-off-by: Alex Guo <alexguo1023@xxxxxxxxx>
---
Build-tested the affected driver object with Clang 18 for ARM
(multi_v7_defconfig). No hardware test was performed.
The patch is correct but I am not sure which tree you applied this to because in my tree (drivers/next) we have not moved to devm_kzalloc_obj() yet.
--
Florian