Re: [RFC PATCH v4 09/10] ksmbd: add provenance time (ptime) and map it to CreationTime

From: Pali Rohár

Date: Thu Nov 19 2026 - 17:09:56 EST


On Thursday 19 November 2026 22:51:26 koraynilay wrote:
> On Thu Nov 19, 2026 at 6:34 PM CET, Amir Goldstein wrote:
> > On Sun, Nov 15, 2026 at 7:04 PM koraynilay <koray.fra@xxxxxxxxx> wrote:
> >>
> >> Implement provenance time (ptime) in ksmbd, as introduced in a
> >> previous commit ("vfs: add provenance time (ptime)").
> >>
> >> Map it to SMB's CreationTime, making it settable by SMB clients. When
> >> reporting CreationTime to clients, prioritize ptime over da.create_time
> >> memorized in the user.DOSATTRIB xattr.
> >
> > That doesn't sound like the right thing to do.
> >
> > If the server stored a CreationTime that client had set, you cannot
> > override this.
>
> Ah, yes, but how would we handle older files which get a custom
> CreationTime both before (in the xattr) and after (in ptime) a kernel
> upgrade?

Just to note that this problem is already there. ksmbd can export for
example ntfs filesystem on removable disk. And this removable disk can
be connected to Windows machine which will always only touch
CreationTime and ignores xattr DOSATTRIB.

> > When the client sets CreationTime, the server can decide if it can and wants
> > (may be a policy decision) to store CreationTime in PTIME and not store
> > it in user.DOSATTRIB.
>
> To fix the above problem we should probably keep storing it in both
> ptime and the xattr though.

IMHO for a long term solution it is better to not have duplicated
information in xattr. Because duplicated information are going to be
out-of-sync. Windows NTFS driver will not update xattr DOSATTRIB.

For me it looks like that this needs some policy / configuration
decision done by user. We do not know if the user will replug that disk
also to Windows NTFS driver (and then those xattr DOSATTRIB could cause
out-of-sync issues) or will only use it from Linux or Samba and then
xattr DOSATTRIB is probably fine.

> > Fun fact: the user.DOSATTRIB format also has a mask so storing the
> > creation time inside it is also optional.
>
> With my current patch series applied, when CreationTime gets set by a
> client, ksmbd writes it to ptime and fixes/heals the xattr (= removing
> the CREATE_TIME flag created by older kernels, see the other fun fact
> below).
>
> And another fun fact: until [1] ksmbd ignored the flags and just
> read/wrote the attribs every time :) so that can only be honored for
> files that have been written to/updated with newer kernels.
> (That's why there is the ((flags & CREATE_TIME) || da.create_time > 0)
> in my patch, and not just the flag check)
>
> Thanks,
> koraynilay
>
> [1]: https://lore.kernel.org/linux-cifs/20261115155308.415734-1-koray.fra@xxxxxxxxx/
>
> > Thanks,
> > Amir.
>
>