Re: [PATCH v2] HID: saitek: don't dereference a NULL hidinput in saitek_event()
From: Jiri Kosina
Date: Thu Nov 19 2026 - 16:38:21 EST
On Thu, 15 Oct 2026, Nguyen Ngoc Thang wrote:
> hid_process_event() calls the driver's ->event() for every usage of a
> report, including fields that hidinput did not map to any input device,
> e.g. a constant input item. For those fields field->hidinput is NULL,
> and saitek_event() loads field->hidinput->input unconditionally:
>
> KASAN: null-ptr-deref in range [0x0000000000000018-0x000000000000001f]
> RIP: 0010:saitek_event+0x51/0x2b0 drivers/hid/hid-saitek.c:154
> hid_process_event drivers/hid/hid-core.c:1572
> hid_report_raw_event drivers/hid/hid-core.c:2109
> hid_input_report drivers/hid/hid-core.c:2180
> hid_irq_in drivers/hid/usbhid/hid-core.c
>
> A device that claims to be a Saitek MMO7 and uses such a descriptor
> triggers it with a single input report.
>
> Bail out early when the input side is not claimed or the field has no
> input device, as the other HID drivers implementing ->event() do. The
> claimed check also covers a failed hidinput_connect(), which frees the
> hid_input structures without clearing field->hidinput.
>
> Fixes: 37c492c8f6a9 ("HID: quirk for Saitek RAT7 and MMO7 mices' mode button")
> Reported-by: syzbot+eba2b3201bd25a97cddf@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=eba2b3201bd25a97cddf
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Nguyen Ngoc Thang <ngocthang2710.1999@xxxxxxxxx>
> ---
> v2: also check HID_CLAIMED_INPUT. hidinput_disconnect() frees the hid_input
> structures without clearing field->hidinput, so after a failed
> hidinput_connect() the pointer dangles while the probe still succeeds
> (->raw_event is set). Reported by Sashiko.
Applied, thanks.
--
Jiri Kosina
SUSE Labs