Re: [PATCH RESEND] char/hpet: Fix missing TASK_RUNNING before put_user() in hpet_read()
From: Arnd Bergmann
Date: Thu Nov 19 2026 - 16:19:10 EST
On Thu, Nov 19, 2026, at 19:28, Habil Eren Türker wrote:
> On Thu, Nov 19, 2026 at 03:02:07PM +0000, Greg Kroah-Hartman wrote:
>> And why hasn't this ever been noticed before, what changed to cause it
>> to show up now? And because of that, why is there not a Fixes: tag?
>
> My initial clone was shallow, so I fetched the full history and repeated
> the investigation. I traced the history of hpet_read().
> The TASK_INTERRUPTIBLE state handling followed by the put_user() call is
> already present in the earliest available Git history, in the initial Git
> import (1da177e4c3f4). I couldn't identify a later commit that introduced
> this behavior.
>
> The 2010 (54066a57c584) and 2024 (4e60131d0d36) changes I examined do not
> appear to have introduced the issue. I couldn't identify a suitable commit
> for a `Fixes:` tag.
I think the warning came from 8eb23b9f35aa ("sched: Debug nested sleeps"),
the behavior seems to be older. Maybe by that time user had moved
on from /dev/hpet to posix timers?
Arnd