Re: [PATCH net v4 0/3] selftests: net: veth: propagate check failures to exit status

From: Jakub Kicinski

Date: Thu Nov 19 2026 - 16:12:24 EST


On Thu, 19 Nov 2026 01:29:40 +0000 Tianyi Gao wrote:
> On Thu, 19 Nov 2026 01:29:59 +0100 Omokefe Emmanuel Onanaroghene wrote:
> > Changes v3 -> v4:
> > - Patch 2: use if/else instead of "&& { ...; } ||" chains, keep
> > lines within 80 columns (thanks Tianyi for the review).
> > - Add patch 3 deriving the invalid tx value from the kernel maximum.
>
> Sorry for being annoying, but I see three problems with how v4 was
> sent:
>
> 1. Patch 3 lost its subject prefix. It went out as "[PATCH] selftests:
> net: veth: derive invalid-tx test value from kernel max", so
> patchwork put it in a series of its own [1].
>
> 2. Patch 3 should come first. Patch 1 makes a chk_channels() failure
> fail the script, and from then on the nproc + 1 check can fail on
> a correct kernel. With the fix first, no commit in the series
> reports a false failure.
>
> 3. v4 was posted as a reply to my review of v3. A new version should
> start a new thread, and its change log should link the previous
> postings [2].

On top of the points Tianyi Gao already made:

4. Please target all your "fixes" for selftests at net-next rather
than net and remove the Fixes: tags. None of this is worth applying
to the current release.

I'm tossing all your submissions from patchwork.
Please don't forget to wait at least 24h before you repost anything.