Re: [PATCH 2/3] Input: wacom_w8001 - assign distinct phys paths to pen and touch devices

From: Ping Cheng

Date: Thu Nov 19 2026 - 16:00:13 EST


On Tue, Oct 13, 2026 at 4:53 PM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> On Tue, Oct 13, 2026 at 03:42:10PM -0700, Jason Gerecke wrote:
> > On Fri, Oct 9, 2026 at 12:28 PM Dmitry Torokhov
> > <dmitry.torokhov@xxxxxxxxx> wrote:
> > >
> > > Previously, both pen and touch input devices used the same phys path
> > > "%s/input0", which made it impossible for userspace or udev rules to
> > > distinguish the devices by physical topology.
> > >
> > > Assign distinct phys paths by introducing separate buffers pen_phys
> > > ("%s/input0") and touch_phys ("%s/input1") in struct w8001. Pass the
> > > corresponding phys path to w8001_allocate_device() during pen and touch
> > > setup, and drop the shared phys buffer from struct w8001.
> > >
> > > Fixes: e0361b70175f ("Input: wacom_w8001 - split the touch and pen devices into two devices")
> >
> > Does this really deserve a "Fixes" tag? This does not seem to be as
> > much of a "bug" as it is a limitation. Userspace and udev rules are
> > (currently) able to reliably distinguish the devices by name.
>
> It is a bug as far as input subsystem is concerned and it was introduced
> in the above referenced commit, so it has this tag.
>
> > Obviously that's not ideal, but I don't see much benefit to this patch
> > getting backported to the stable trees -- especially when /existing/
> > udev rules aren't necessarily going to know what to do with this new
> > "input1" phys.
>
> Right. For input subsystem only commits that are explicitly marked
> as Cc: stable@ will be backported to stable trees, so it should not be
> a concern.

Hi Dmitry,

Did you merge this set? I don't see it in the upstream repo.

Thank you,
Ping