Re: [PATCH v2 00/33] HID: logitech-hidpp: G920 force-feedback fixes, rework, and cleanups
From: Jiri Kosina
Date: Thu Nov 19 2026 - 15:19:45 EST
On Tue, 10 Nov 2026, Dmitry Torokhov wrote:
> This series starts from Gideon Heinz's report of Logitech G920
> force-feedback initialization timing out in v7.3 and addresses several
> additional pre-existing bugs, lifetime races, and cleanup opportunities
> found while auditing hid-logitech-hidpp.
>
> The first 14 patches carry Fixes and stable tags. They fix the v7.3
> G920 force-feedback initialization timeout by temporarily enabling
> device I/O around g920_get_config() in hidpp_input_configured(), switch
> hidpp_ff_queue_work() to GFP_ATOMIC since playback, gain, and autocenter
> callbacks run under the input event spinlock, drain the G920 FF
> workqueue before closing the HID transport on input close so queued
> commands still receive their USB interrupt IN replies, synchronously
> disable driver work items and disconnect input devices with device I/O
> enabled before stopping the transport on removal and probe failure,
> avoid storing an ERR_PTR in battery->ps on registration failure, avoid
> NULL pointer subtraction in the HID++ 1.0 consumer keys report fixup,
> and fix an off-by-one in G920 slot tracking that made the 63rd user
> effect in hardware slot 64 unusable and leaked it across reopen.
>
> Additionally in the bug fix section, hidpp_send_message_sync() is
> updated to stop retrying non-busy errors (timeouts and transport
> failures) so failed commands fail promptly without 15-second stalls,
> and response buffers are initialized before publishing send_receive_buf
> to eliminate races with concurrent or spurious packets. Battery fixes
> correct HID++ 1.0 battery mileage event parsing to read capacity from
> the correct report byte and update state, properly propagate negative
> transport and timeout errors in ADC measurement (0x1f20) queries, mark
> devices online when receiving unified battery (0x1004) events, fix K750
> solar battery feature lookup and reconnect handling, and expose the
> charge_type property for the battery voltage (0x1001) feature.
>
> The next section prepares transport handling and reworks G920 force
> feedback for next. Connect-event work is kept disabled in probe until
> hid_connect() completes successfully. Transport error codes are
> preserved in __hidpp_send_report(), and hidpp_send_message_sync()
> is switched to return standard negative error codes on failure.
> G920 capability discovery moves back into hidpp_probe() while device
> I/O is active (keeping force feedback optional on failure and
> excluding generic USB PID force feedback), device-level wheel settings
> are separated from the input FF queue lifetime, the G920 range sysfs
> attribute moves to driver dev_groups, and FF workqueue teardown moves
> into ff->stop so open evdev handles across USB disconnect or unbind
> no longer cause use-after-free.
>
> Furthermore, G920 range store, effect upload, and effect erase are
> converted to execute synchronously with proper transport lifetime
> handling, avoiding asynchronous command queueing and work flushing
> during device close and teardown. Effect slot lookup is streamlined by
> indexing slot arrays directly by effect ID instead of performing linear
> scans.
>
> The final section modernizes the driver. Multi-byte packet fields are
> switched to unaligned accessors, the device serial is stored as a byte
> array, and resource management is updated to use guard(mutex),
> __free(kfree), alloc_ordered_workqueue(), devm_mutex_init(), and
> devm_device_add_group(). Lastly, unused kfifo fields and helpers
> are removed.
>
> Note that device removal teardown still has limitations due to how HID
> core's hid_device_io_start() and hid_device_io_stop() (via
> driver_input_lock) gate both driver raw command/response I/O and
> subdriver event forwarding, disabling I/O before .remove() and
> hid_disconnect(). For instance, HIDPP_QUIRK_DELAYED_INIT devm-managed
> input devices are still unregistered after hid_hw_stop(), and
> hidpp_connect_event() publishes hidpp->input before input registration
> completes. Resolving these teardown edge cases cleanly will require
> follow-up work in HID core and driver input registration.
Wow, what an endeavor. Thanks for looking into all this.
I've finally got to processing it. I've applied 1-14 to
for-7.4/upstream-fixes and the rest on top of it to for-7.5/logitech.
Thanks,
--
Jiri Kosina
SUSE Labs