Re: [PATCH net] tg3: Propagate PHY reset retry failures in tg3_phy_reset_5703_4_5()

From: Andrew Lunn

Date: Thu Nov 19 2026 - 15:15:42 EST


On Thu, Nov 19, 2026 at 09:10:21AM -0800, Ian Rogers wrote:
> In tg3_phy_reset_5703_4_5(), the 10-iteration retry loop discards the
> return value of both tg3_readphy() calls on continue and never checks
> err after the loop terminates. If MDIO reads fail across all 10
> retries,

If it fails 10 times, the hardware is dead, and there is no
recovery. The best you can do is make the probe fail.

> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

This clearly does not bother anybody.

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Andrew