Re: [PATCH 2/2] devicetable-offsets: Get struct cpu_feature from a device-id header
From: Nathan Chancellor
Date: Thu Nov 19 2026 - 14:47:49 EST
On Thu, Nov 19, 2026 at 04:24:47PM +0100, Nicolas Schier wrote:
> On Mon, Nov 09, 2026 at 05:07:05PM +0100, Nicolas Schier wrote:
> > Applied to kbuild/linux.git (kbuild-next-unstable), thanks!
> >
> > [2/2] devicetable-offsets: Get struct cpu_feature from a device-id header
> > https://git.kernel.org/kbuild/c/50ccc340
>
> I applied this fix on kbuild-next-unstable (and rebased today [1]), two
> commits after "Move struct cpu_feature to <linux/cpufeature.h>" [2],
> which is being "fixed" by this patch.
>
> If we keep it this way, a bisect may hit the issue; folding does not
> look correct to me as that would mix-up related but different things.
Yeah, good catch.
> So my questions:
>
> * Shall we keep it the way it is to keep the original patch order
> (bisect might fail on the two commits before this patch)?
>
> * Or shall the patch be moved before Uwe's (removing the 'Fixes' tag,
> and rewriting the commit msg)?
>
> I am in favor of the latter. Are there any objections?
>
>
> [1]: https://git.kernel.org/kbuild/c/f1dc66c38b7eb4b2fb946a2fd6929250ecd2d85a
> [2]: https://patch.msgid.link/bc9fbf5784f6788e10c749a05d56c42bdb68f3d9.1792144769.git.u.kleine-koenig@xxxxxxxxxxxx
If history is already being rewritten, I believe it is always good to
fix potential bisection issues like this. Rewriting the commit message
(and maybe some of the diff?) and placing it in an order such that the
build cannot break sounds great to me (but others are free to disagree).
--
Cheers,
Nathan