Re: [PATCH net-next] aqc111: Correct endianness handling in rx/tx_fixup

From: Andrew Lunn

Date: Thu Nov 19 2026 - 14:41:32 EST


> - desc_hdr = le64_to_cpup((u64 *)skb_tail_pointer(skb));
> + desc_hdr = get_unaligned_le64((__le64 *)skb_tail_pointer(skb));

static inline u64 get_unaligned_le64(const void *p)
{
return le64_to_cpu(__get_unaligned_t(__le64, p));
}

You should cast to a void *, not __le64 *. I'm not even sure a cast is
needed:

static inline unsigned char *skb_tail_pointer(const struct sk_buff *skb)
{
return skb->head + skb->tail;
}

The compiler should do an implicit cast.

Andrew