[PATCH] NFSD: Reject a COPY whose source and destination are the same file

From: Jeff Layton

Date: Thu Nov 19 2026 - 12:43:07 EST


RFC 7862 Section 15.2.3 says that COPY MUST fail with NFS4ERR_INVAL
when SAVED_FH and CURRENT_FH refer to the same file, whatever the
ranges. NFSD never checks for this. A same-file COPY with
non-overlapping ranges succeeds, and one with overlapping ranges fails
only because the VFS rejects it.

The overlap-only rule applies to CLONE (Section 15.13.3), so leave
nfsd4_verify_copy() alone. Instead, check in nfsd4_setup_intra_ssc(),
after both stateids are verified. For an inter-server copy, SAVED_FH
names a file on another server, so that path is not affected.

The Linux client never sends a same-file COPY, so this does not change
its behaviour. Found by pynfs COPY11.

Fixes: 29ae7f9dc21a ("NFSD: Implement the COPY call")
Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
---
fs/nfsd/nfs4proc.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 9fba2b67cce2..27e9cd7ebf59 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -2107,9 +2107,23 @@ nfsd4_setup_intra_ssc(struct svc_rqst *rqstp,
struct nfsd4_compound_state *cstate,
struct nfsd4_copy *copy)
{
- return nfsd4_verify_copy(rqstp, cstate, &copy->cp_src_stateid,
- &copy->nf_src, &copy->cp_dst_stateid,
- &copy->nf_dst);
+ __be32 status;
+
+ status = nfsd4_verify_copy(rqstp, cstate, &copy->cp_src_stateid,
+ &copy->nf_src, &copy->cp_dst_stateid,
+ &copy->nf_dst);
+ if (status)
+ return status;
+
+ /*
+ * RFC 7862 Section 15.2.3: COPY MUST fail with NFS4ERR_INVAL when
+ * SAVED_FH and CURRENT_FH refer to the same file, whether or not the
+ * ranges overlap. The caller releases nf_src and nf_dst.
+ */
+ if (file_inode(copy->nf_src->nf_file) ==
+ file_inode(copy->nf_dst->nf_file))
+ return nfserr_inval;
+ return nfs_ok;
}

static void nfsd4_cb_offload_release(struct nfsd4_callback *cb)

---
base-commit: 00270637d0d956cd6343c41bfd9220ba90360fac
change-id: 20261119-nfsd-copy-same-file-2477054222d6

Best regards,
--
Jeff Layton <jlayton@xxxxxxxxxx>