Re: [PATCH] serial: sc16is7xx: Use devm_clk_get_optional_enabled() in sc16is7xx_probe()
From: Hugo Villeneuve
Date: Thu Nov 19 2026 - 12:36:43 EST
Hi Markus,
On Thu, 19 Nov 2026 18:12:33 +0100
Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 19 Nov 2026 18:04:56 +0100
>
> Reuse existing functionality from devm_clk_get_optional_enabled()
> instead of keeping duplicate source code.
>
> The source code was transformed by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/sc16is7xx.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index dbf38825a78c..3af8ea93b34a 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1605,14 +1605,10 @@ int sc16is7xx_probe(struct device *dev, const struct sc16is7xx_devtype *devtype,
> dev_dbg(dev,
> "No interrupt pin definition, falling back to polling mode\n");
>
> - s->clk = devm_clk_get_optional(dev, NULL);
> + s->clk = devm_clk_get_optional_enabled(dev, NULL);
> if (IS_ERR(s->clk))
> return PTR_ERR(s->clk);
>
> - ret = clk_prepare_enable(s->clk);
> - if (ret)
> - return ret;
> -
> freq = clk_get_rate(s->clk);
> if (freq == 0) {
> if (uartclk)
Nak, your patch is incomplete and in fact just duplicates, in part,
what Xiangwu's patch does:
https://lore.kernel.org/all/20261113103855.2144-1-laixiangwu@xxxxxxxxxxxxxxxxxxxx/
--
Hugo Villeneuve