Re: [PATCH v2] hwmon: (ads7871) Add error handle from spi_setup()

From: Guenter Roeck

Date: Thu Nov 19 2026 - 11:50:02 EST


On Wed, Nov 18, 2026 at 09:29:28AM +0000, Vítor Hugo Silva wrote:
> The ads7871 probe() ignores the spi_setup() error return value
> and it attempts to write to registers even if spi_setup() fails.
>
> Return the setup error before accessing any registers.
>
> AI was used for peer-review the patch.
>
> Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
>
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@xxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
> Changes in v2:
> - Clarify what happens when spi_setup() fails.
> - Describe the fix in imperative mood.
>
> drivers/hwmon/ads7871.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
> index 36297bc6d047..a1ffc35d9272 100644
> --- a/drivers/hwmon/ads7871.c
> +++ b/drivers/hwmon/ads7871.c
> @@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
> /* Configure the SPI bus */
> spi->mode = (SPI_MODE_0);
> spi->bits_per_word = 8;
> - spi_setup(spi);
> + ret = spi_setup(spi);
> + if (ret)
> + return ret;
>
> pdata = devm_kzalloc_obj(dev, *pdata);
> if (!pdata)