[PATCH] mm/gup: unshare-check every page of a pte batch

From: Rik van Riel

Date: Thu Nov 19 2026 - 10:57:52 EST


A write pin over a PTE batch can hand back pages that a later
write fault replaces under the pin holder: the process writes to
the copy, the holder keeps the old page:

pin holder process (mm owner)
pin all 16 for write
batch passes unchecked
write to a tail page
fault copies it elsewhere
read pinned page -> stale

For every FOLL_WRITE call the helper returns the whole run on
the head page's credentials, never reaching the per-page loop below.
After fork, a FOLL_FORCE write unsharing only the head leaves
the tail pages read-only and non-exclusive behind identical
PTEs, which batching (PTE bits only, never the exclusivity flag)
covers at once.

A page pinned for write must be exclusive to the pinning process,
and one vetted PTE proves that for one page only. FOLL_GET and
single-page FOLL_WRITE keep the shortcut; multi-page callers run
the per-page check. Writable batches and GUP-fast are unchanged.

Without this fix, the pin holder sees stale page content,
with it the pin and program address map the same page.

Signed-off-by: Rik van Riel <riel@xxxxxxxxxxx>
---
This fix applies on gup-7.5-ptebatch in mm/core.git

mm/gup.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/mm/gup.c b/mm/gup.c
index b0a0019de80a..6b6e4c6f8144 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -639,15 +639,25 @@ static unsigned long gup_pages_not_requiring_unshare(
{
unsigned int i;

+ /* A short term reference does not need the pages to be exclusive. */
+ if (!(flags & FOLL_PIN))
+ return nr_pages;
+
/*
- * FOLL_WRITE is implicitly handled correctly as the page table entry
- * has to be writable -- and if it references (part of) an anonymous
- * folio, that part is required to be marked exclusive.
+ * FOLL_WRITE for a single page is checked by the caller, which
+ * checked that the page table entry is writable, or FOLL_FORCE
+ * on an exclusive anonymous page; if it references (part of) an
+ * anonymous folio, that is exclusive.
*/
- if ((flags & (FOLL_WRITE | FOLL_PIN)) != FOLL_PIN)
+ if ((flags & FOLL_WRITE) && nr_pages == 1)
return nr_pages;

- /* folio_test_anon(folio) is stable until folio gets freed. */
+ /*
+ * Check each page for suitability below. The caller may have
+ * only checked the page tables.
+ *
+ * folio_test_anon(folio) is stable until folio gets freed.
+ */
if (!folio_test_anon(folio)) {
/*
* We only care about R/O long-term pining: R/O short-term
--
2.56.0