[PATCH 06/10] iio: adc: pac1934: Fix custom attribute allocation and channel bounds

From: Lee Jones

Date: Thu Nov 19 2026 - 10:33:18 EST


pac1934_prep_custom_attributes() sizes the pac1934_custom_attr pointer
array using sizeof(*pac1934_group) instead of
sizeof(*pac1934_custom_attr) and adds 1 byte rather than one pointer
element for the terminating NULL entry. When active_channels_count is
zero, only a single byte is allocated and iio_device_register_sysfs()
reads past the allocation when scanning the attribute list.

In addition, active_channels_count is counted over info->phys_channels,
whereas the population steps unconditionally inspect all four entries of
info->active_channels[], which can write past the end of the array on
1-, 2-, and 3-channel chip variants.

Allocate active_channels_count + 1 attribute pointers with
devm_kzalloc_objs() and bound the population loop by
info->phys_channels.

Fixes: 0fb528c8255b ("iio: adc: adding support for PAC193x")
Closes: https://sashiko.dev/#/bug/linux-e7b7eab1-9ed4-4d4b-b9c7-889bf720aa5b
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Lee Jones <lee@xxxxxxxxxx>
---
drivers/iio/adc/pac1934.c | 33 +++++++++++++++------------------
1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
index 1d7608e8246a..c3da0c519456 100644
--- a/drivers/iio/adc/pac1934.c
+++ b/drivers/iio/adc/pac1934.c
@@ -1435,10 +1435,17 @@ static IIO_DEVICE_ATTR(in_shunt_resistor3, 0644,
static IIO_DEVICE_ATTR(in_shunt_resistor4, 0644,
pac1934_shunt_value_show, pac1934_shunt_value_store, 3);

+static struct attribute * const pac1934_shunt_attrs[] = {
+ PAC1934_DEV_ATTR(in_shunt_resistor1),
+ PAC1934_DEV_ATTR(in_shunt_resistor2),
+ PAC1934_DEV_ATTR(in_shunt_resistor3),
+ PAC1934_DEV_ATTR(in_shunt_resistor4),
+};
+
static int pac1934_prep_custom_attributes(struct pac1934_chip_info *info,
struct iio_dev *indio_dev)
{
- int i, active_channels_count = 0;
+ int i, j, active_channels_count = 0;
struct attribute **pac1934_custom_attr;
struct attribute_group *pac1934_group;
struct device *dev = &info->client->dev;
@@ -1451,26 +1458,16 @@ static int pac1934_prep_custom_attributes(struct pac1934_chip_info *info,
if (!pac1934_group)
return -ENOMEM;

- pac1934_custom_attr = devm_kzalloc(dev,
- (PAC1934_CUSTOM_ATTR_FOR_CHANNEL *
- active_channels_count)
- * sizeof(*pac1934_group) + 1,
- GFP_KERNEL);
+ pac1934_custom_attr = devm_kzalloc_objs(dev, *pac1934_custom_attr,
+ PAC1934_CUSTOM_ATTR_FOR_CHANNEL *
+ active_channels_count + 1);
if (!pac1934_custom_attr)
return -ENOMEM;

- i = 0;
- if (info->active_channels[0])
- pac1934_custom_attr[i++] = PAC1934_DEV_ATTR(in_shunt_resistor1);
-
- if (info->active_channels[1])
- pac1934_custom_attr[i++] = PAC1934_DEV_ATTR(in_shunt_resistor2);
-
- if (info->active_channels[2])
- pac1934_custom_attr[i++] = PAC1934_DEV_ATTR(in_shunt_resistor3);
-
- if (info->active_channels[3])
- pac1934_custom_attr[i] = PAC1934_DEV_ATTR(in_shunt_resistor4);
+ j = 0;
+ for (i = 0; i < info->phys_channels; i++)
+ if (info->active_channels[i])
+ pac1934_custom_attr[j++] = pac1934_shunt_attrs[i];

pac1934_group->attrs = pac1934_custom_attr;
info->iio_info.attrs = pac1934_group;
--
2.56.1.708.g77570a6a1d-goog