Re: [PATCH net v5 0/4] bnxt_en: Make RING FREE more robust
From: Joe Damato
Date: Thu Nov 19 2026 - 10:16:39 EST
On Tue, Nov 17, 2026 at 03:04:09PM -0800, Michael Chan wrote:
> On Tue, Nov 17, 2026 at 8:10 AM Joe Damato <joe@xxxxxxx> wrote:
> > One more question before I put together v6.
> >
> > bnxt_reset() is also called for the silent reset on a VF: the
> > VF_CFG_CHANGE async event sets BNXT_RESET_TASK_SILENT_SP_EVENT, and
> > bnxt_sp_task() calls bnxt_reset(bp, true). With the ULP patch as planned,
> > RoCE on the VF would be stopped and restarted every time the PF changes
> > that VF's config.
> >
> > Not sure how often config changes happen with RoCE in use on VFs? If not
> > often, then treating silent and non-silent resets the same should be OK.
> > The cost is a brief RoCE restart on the VF for every config change.
> >
>
> VF_CFG_CHANGE is to notify the VF about changes such as default VLAN.
> Unlike a TX timeout, this is a normal config change and I think we
> shouldn't disrupt RoCE unnecessarily. It's unlikely to run into
> errors during the config change. Selvin and Kalesh, please comment as
> well. Thanks.
I didn't hear back from Selvin of Kalesh, but I think we discussed enough in
this thread that I can put together a reasonable v6 that (I hope) will be
acceptable.