Re: [PATCH v4 03/16] dt-bindings: clock: at91: Allow referencing main rc oscillator in DT
From: Alexander Dahl
Date: Thu Nov 19 2026 - 09:56:56 EST
Hello Claudiu,
Am Sun, Nov 15, 2026 at 04:34:30PM +0200 schrieb Claudiu Beznea:
> Hi, Alexander,
>
> On 11/5/26 13:06, Alexander Dahl wrote:
> > The main rc oscillator will be needed for the OTPC to work properly.
> >
> > The new index introduced here was not used on the four affected SoC
> > clock drivers before.
> >
> > Link: https://lore.kernel.org/linux-devicetree/20250207-jailbird-circus-bcc04ee90e05@xxxxxxxxxxx/T/#u
> > Signed-off-by: Alexander Dahl <ada@xxxxxxxxxxx>
> > ---
> >
> > Notes:
> > v4:
> > - change index for sama7g5 and sama7d65 after re-adding unused PLLs in patch 2
> > v3:
> > - adapt to different base changes, added lines are the same
> > v2:
> > - new patch, not present in v1
> >
> > include/dt-bindings/clock/microchip,sam9x60-pmc.h | 1 +
> > include/dt-bindings/clock/microchip,sam9x7-pmc.h | 1 +
> > include/dt-bindings/clock/microchip,sama7d65-pmc.h | 1 +
> > include/dt-bindings/clock/microchip,sama7g5-pmc.h | 1 +
> > 4 files changed, 4 insertions(+)
> >
> > diff --git a/include/dt-bindings/clock/microchip,sam9x60-pmc.h b/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> > index 050e5e774b274..830e247ba2532 100644
> > --- a/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> > +++ b/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> > @@ -10,6 +10,7 @@
> > #define SAM9X60_PMC_MCK 1
> > #define SAM9X60_PMC_UPLLCK 2
> > #define SAM9X60_PMC_MAIN 3
> > +#define SAM9X60_PMC_MAIN_RC 6
> > #define SAM9X60_PMC_PLLACK 7
> > #endif
> > diff --git a/include/dt-bindings/clock/microchip,sam9x7-pmc.h b/include/dt-bindings/clock/microchip,sam9x7-pmc.h
> > index 292c5873e101e..58d2a08116795 100644
> > --- a/include/dt-bindings/clock/microchip,sam9x7-pmc.h
> > +++ b/include/dt-bindings/clock/microchip,sam9x7-pmc.h
> > @@ -10,6 +10,7 @@
> > #define SAM9X7_PMC_MCK 1
> > #define SAM9X7_PMC_UPLLCK 2
> > #define SAM9X7_PMC_MAIN 3
> > +#define SAM9X7_PMC_MAIN_RC 6
> > #define SAM9X7_PMC_PLLACK 7
> > #define SAM9X7_PMC_AUDIOPMCPLL 9
> > #define SAM9X7_PMC_AUDIOIOPLL 10
> > diff --git a/include/dt-bindings/clock/microchip,sama7d65-pmc.h b/include/dt-bindings/clock/microchip,sama7d65-pmc.h
> > index 08581418b9115..17105a6bedb54 100644
> > --- a/include/dt-bindings/clock/microchip,sama7d65-pmc.h
> > +++ b/include/dt-bindings/clock/microchip,sama7d65-pmc.h
> > @@ -19,6 +19,7 @@
> > #define SAMA7D65_PMC_AUDIOIOPLL 10
> > #define SAMA7D65_PMC_ETHPLL 11
> > #define SAMA7D65_PMC_MCK1 13
> > +#define SAMA7D65_PMC_MAIN_RC 14
> > #define SAMA7D65_PMC_LVDSPLL 15
> > #define SAMA7D65_PMC_MCK3 16
> > #define SAMA7D65_PMC_MCK5 17
> > diff --git a/include/dt-bindings/clock/microchip,sama7g5-pmc.h b/include/dt-bindings/clock/microchip,sama7g5-pmc.h
> > index 27668634b0a2b..4a1c4af8ecc9a 100644
> > --- a/include/dt-bindings/clock/microchip,sama7g5-pmc.h
> > +++ b/include/dt-bindings/clock/microchip,sama7g5-pmc.h
> > @@ -19,5 +19,6 @@
> > #define SAMA7G5_PMC_AUDIOIOPLL 10
> > #define SAMA7G5_PMC_ETHPLL 11
> > #define SAMA7G5_PMC_MCK1 13
> > +#define SAMA7G5_PMC_MAIN_RC 14
>
> I think we can use 12 instead. Correct me if I'm wrong. Otherwise, you
> should change also driver code to allocate space for this clock. See
> pmc_data_allocate() in drivers/clk/at91/sama7g5.c
The old definition had this (with PMC_MAIN = 3):
#define PMC_CPU (PMC_MAIN + 9)
That's the 12 which is missing in the new list. PMC_CPU was not used
in the current code base. Personally I'm fine with using 12 here, but
I was not sure if this is again some value Microchip wants to keep for
some reason?
The allocation problem was found by sashiko on patch 5. I already
fixed that in my working copy for v5 of the series, but will adapt, if
the value here is changed again.
Greets
Alex