Re: [PATCH v2 0/3] jbd2: check return value of blkdev_issue_flush()
From: Theodore Ts'o
Date: Thu Nov 19 2026 - 09:48:26 EST
On Tue, 13 Oct 2026 01:40:25 +0000, guolingxing wrote:
> Check the return value of blkdev_issue_flush() in three JBD2 paths
> where it was ignored, and abort the journal on failure. This prevents
> journal tail updates or successful transaction completion from
> proceeding without the required cache flush succeeding.
>
> Changes since v1:
> - 1/3: collected Reviewed-by from Jan Kara.
> - 2/3: reuse the existing err variable instead of declaring a new
> one that shadows it, per review from Jan Kara.
> - 3/3: use flush_err to avoid shadowing err, preserve any earlier
> commit-record error, and reuse the existing abort handling,
> as suggested by Jan Kara.
>
> [...]
Applied, thanks!
[1/3] jbd2: check return value of blkdev_issue_flush() when checkpointing
commit: 74dead67b289a4e8543b03ebacf42279f0e8cfad
[2/3] jbd2: check return value of blkdev_issue_flush() when committing
commit: 0be51944deaa666d93fc4b67960b495ca09a4721
[3/3] jbd2: check return value of blkdev_issue_flush() for async commits
commit: b96c1535348e378847b53c5149f5b5f260ce459a
Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>