Re: [PATCH v6 1/5] dt-bindings: usb: ci-hdrc-usb2: add spacemit,k1-usb2 compatible

From: Krzysztof Kozlowski

Date: Thu Nov 19 2026 - 09:09:29 EST


On 19/11/2026 14:41, Junzhong Pan wrote:
> The USB2.0 controller on the SpacemiT K1 SoC is dual-role capable but
> has no internal OTG registers, this requires flags which disable
> related features set in platform data. Add a compatible string to match
> the platform data.
>
> Chipidea USB2 Controller on SpacemiT K1 requires 1 clock and 1 reset to
> work, add constraints for it.
>
> Reviewed-by: Yixun Lan <dlan@xxxxxxxxxx>

Hm, I could not locate this tag. Where did it happen?

> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Junzhong Pan <panjunzhong@xxxxxxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> index 620b564914d4..5c2b7eb1a6ff 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> @@ -25,6 +25,7 @@ properties:
> - nvidia,tegra124-udc
> - nxp,s32g2-usb
> - qcom,ci-hdrc
> + - spacemit,k1-usb2
> - items:
> - enum:
> - nvidia,tegra114-ehci
> @@ -113,6 +114,20 @@ allOf:
> maxItems: 2
> clock-names:
> maxItems: 2
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: spacemit,k1-usb2
> + then:
> + properties:
> + clocks:
> + maxItems: 1

Were are the clock-names constraints?

> + resets:
> + minItems: 1

This is odd. Why do you need minItems? What are the constraints?

This looks just wrong...


> + required:
> + - clocks
> + - resets
>
> unevaluatedProperties: false
>
>


Best regards,
Krzysztof