Re: [PATCH 01/11] nvmem: retain the provider node until device release
From: Bartosz Golaszewski
Date: Thu Nov 19 2026 - 08:52:39 EST
On Tue, Nov 17, 2026 at 12:38:08PM -0700, James Hilliard wrote:
> An NVMEM device can remain referenced after its provider unregisters.
> Keep a reference to its OF node so retained devices do not depend on the
> provider retaining the node. Drop that reference in the device release
> callback, including registration-error paths.
>
> Fixes: 1333a6779501 ("nvmem: core: allow specifying of_node")
> Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx>
> ---
> drivers/nvmem/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 7d4cce8e2742..802637f375f8 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -570,6 +570,7 @@ static void nvmem_release(struct device *dev)
> gpiod_put(nvmem->wp_gpio);
> nvmem_device_remove_all_cells(nvmem);
> ida_free(&nvmem_ida, nvmem->id);
> + of_node_put(nvmem->dev.of_node);
> cleanup_srcu_struct(&nvmem->srcu);
> kfree(nvmem);
> }
> @@ -973,9 +974,9 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
> nvmem->keepout = config->keepout;
> nvmem->nkeepout = config->nkeepout;
> if (config->of_node)
> - nvmem->dev.of_node = config->of_node;
> + nvmem->dev.of_node = of_node_get(config->of_node);
> else
> - nvmem->dev.of_node = config->dev->of_node;
> + nvmem->dev.of_node = of_node_get(config->dev->of_node);
While at it, you could switch to using device_set_of_node_from_dev().
Bart
>
> switch (config->id) {
> case NVMEM_DEVID_NONE:
>
> --
> 2.53.0
>