Re: [PATCH v2] docs: submitting-patches: ask bug fixes for their user-visible impact

From: Willy Tarreau

Date: Thu Nov 19 2026 - 07:58:41 EST


On Thu, Nov 19, 2026 at 02:54:50PM +0200, Leon Romanovsky wrote:
> On Thu, Nov 19, 2026 at 01:36:51PM +0100, Willy Tarreau wrote:
> > On Thu, Nov 19, 2026 at 01:04:32PM +0100, Krzysztof Kozlowski wrote:
(...)
> > > Depending on the case, e.g. some driver lockdep reports don't need them.
> > > NULL ptr usually as well. The point is that dmesg should be trimmed to
> > > relevant and useful information. If that includes addresses for that
> > > particular case, then of course these should stay. But 75% of data here
> > > in commit like 5b4bd13e0552926648a46c2c9a12a24dfaee3715 is not really
> > > helping. In the same time undecoded call trace is useless, because these
> > > addresses depends on the build. The dmesg should simply be the decoded
> > > stacktrace ONLY for this case.
> >
> > Then just the 2-3 lines capture inline, and the full log attached could
> > please everyone ?
>
> I don't think so, because this information is also important to preserve in the
> Git history. I received offline feedback that the full stack is useful for
> backporting and customer support, too. Sometimes the dmesg output is similar
> enough to recognize, but differs in two or three lines.

Good point and several times as a user facing an bugs I've looked for
messages in history as well before asking for help.

> I welcome AI-generated patches, but they should not be trusted blindly.
> I also don't believe AI can reliably trim stack traces.

Never trusted indeed, however running "sed -n first,last,p" is now quite
common and reliable since the LLM generates the extraction/trimming command,
not the contents anymore.

Willy