Re: [PATCH v2] ALSA: dmaengine: Check DMA submission errors
From: Takashi Iwai
Date: Thu Nov 19 2026 - 07:56:28 EST
On Thu, 19 Nov 2026 08:36:53 +0100,
Sreeraj S Kurup wrote:
>
> The dmaengine_pcm_prepare_and_submit() function does not check
> the return value of dmaengine_submit().
>
> dmaengine_submit() can return a negative DMA cookie if the
> submission fails. However, the function currently returns
> success unconditionally.
>
> This makes the PCM trigger path believe that DMA has been
> successfully submitted, even when the submission has failed.
>
> Use dma_submit_error() to check the returned DMA cookie and
> propagate the error to the caller.
>
> This ensures that DMA submission failures are properly
> reported instead of allowing the PCM stream to continue
> as if the DMA transfer had started successfully.
>
> Fixes: e7f73a161356 ("ASoC: Add dmaengine PCM helper functions")
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@xxxxxxxxx>
Applied now. Thanks.
Takashi