Re: [PATCH v2] docs: submitting-patches: ask bug fixes for their user-visible impact

From: Krzysztof Kozlowski

Date: Thu Nov 19 2026 - 07:04:48 EST


On 19/11/2026 12:19, Leon Romanovsky wrote:
> On Thu, Nov 19, 2026 at 11:13:57AM +0100, Krzysztof Kozlowski wrote:
>>>> v1: https://lore.kernel.org/r/20261116191436.188098-1-sashal@xxxxxxxxxx
>>>>
>>>> Documentation/process/coding-assistants.rst | 6 +++--
>>>> Documentation/process/submitting-patches.rst | 23 ++++++++++++++++++++
>>>> 2 files changed, 27 insertions(+), 2 deletions(-)
>>>
>>> Sasha,
>>>
>>> Since you're already making changes in that area, could you add a sentence
>>> asking reporters to provide the full dmesg stack trace?
>>
>> If so, then trimmed. We do not need all addresses and registers and the
>> [time markers], but rather the calltrace from decode_stacktrace.sh.
>
> Regarding time markers, I agree. However, addresses are an important part of
> debugging information. These bugs are rare, but addresses are still useful for
> identifying incorrect pointer arithmetic or pointer assignments.

Depending on the case, e.g. some driver lockdep reports don't need them.
NULL ptr usually as well. The point is that dmesg should be trimmed to
relevant and useful information. If that includes addresses for that
particular case, then of course these should stay. But 75% of data here
in commit like 5b4bd13e0552926648a46c2c9a12a24dfaee3715 is not really
helping. In the same time undecoded call trace is useless, because these
addresses depends on the build. The dmesg should simply be the decoded
stacktrace ONLY for this case.

Best regards,
Krzysztof