Re: [RFC PATCH v2 1/2] drm/msm: release the cursor flip work before the KMS is torn down
From: Yaohan Li
Date: Thu Nov 19 2026 - 06:19:00 EST
Hi,
thanks for the review. You are right, and the check is redundant in the
current mdp4 code: mdp4_destroy() dereferences mdp4_kms->dev at the top,
before the new guard.
The guard only protects the CRTC traversal this patch adds, and the v2
commit message says that it does not make mdp4_destroy() safe for every
partial-initialization state. The existing problem belongs to the separate
KMS initialization error-handling series ("drm/msm: fix the error handling
of the KMS init"), which was not merged in the msm-next baseline used for
this RFC.
I would prefer to keep this change focused on the cursor flip-work
lifetime; if the check is more noise than it is worth, I can drop it in a
follow-up revision.
Thanks,
Yaohan