[PATCH v3 0/3] dm thin: stop waiting for grace periods when activating and removing thins
From: Qiliang Yuan
Date: Thu Nov 19 2026 - 06:05:27 EST
Activating a thin device waits for an RCU grace period in thin_ctr(),
and removing one waits for another in thin_dtr(). Tools that create and
remove thin snapshots for every container, such as the containerd
devmapper snapshotter, pay for both each time.
Patch 1 drops the grace period from thin_ctr(), which isn't needed.
Patch 2 fixes the pool worker continuing its walk of active_thins from a
thin that thin_dtr() already took off the list, whose successor may have
been freed: thin_dtr() now marks the thin as dying and takes it off the
list only after its last reference is dropped. Patch 3 then lets
thin_dtr() free the thin with kfree_rcu() instead of waiting. Activating
a thin device gets 50% faster and removing one 20%.
Signed-off-by: Qiliang Yuan <qiliang.yuan@xxxxxxxxx>
---
V2 -> V3:
- Patch 2: mark the thin as dying in thin_dtr(), take it off
active_thins after wait_for_completion() instead of in the last
thin_put(), and skip dying thins in requeue_bios() and
error_retry_list_with_code() (Benjamin Marzinski)
- Patch 2: correct the Fixes tag to 17181fb7a0c3 (Benjamin Marzinski)
- Patch 3: keep kfree_rcu() out of patch 2, so that the fix can go to
stable on its own
- Rebase onto current mainline and remeasure
V1 -> V2:
- Add patch 2: keep a thin on active_thins until its last reference is
dropped, so that the worker never continues from a thin whose
successor was freed (Benjamin Marzinski)
- Patch 3: rebase onto patch 2, which already skips dying thins, so it
only replaces the grace period with kfree_rcu()
- Patch 1: add Benjamin's Reviewed-by
- Rebase onto current mainline and remeasure
v2: https://lore.kernel.org/r/20261119-bug-dm-thin-rcu-gp-v2-0-055d627763c3@xxxxxxxxx
v1: https://lore.kernel.org/r/20261116-bug-dm-thin-rcu-gp-v1-0-14ed3567da3e@xxxxxxxxx
---
Qiliang Yuan (3):
dm thin: drop the grace period from thin_ctr()
dm thin: keep a thin on active_thins until its last reference is dropped
dm thin: free thins with kfree_rcu() instead of waiting in thin_dtr()
drivers/md/dm-thin.c | 61 +++++++++++++++++++++++++++++++---------------------
1 file changed, 36 insertions(+), 25 deletions(-)
---
base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
change-id: 20261114-bug-dm-thin-rcu-gp-d29d4b74a0b8
Best regards,
--
Qiliang Yuan <qiliang.yuan@xxxxxxxxx>