Re: [PATCH net] net/sched: sch_cake: fix unintended tin override with cake_mq

From: Toke Høiland-Jørgensen

Date: Thu Nov 19 2026 - 04:50:15 EST


Jonas Köppeler <j.koeppeler@xxxxxxxxxxxx> writes:

> CAKE allows overriding the tin selection through skb->priority: if the
> major number of skb->priority matches the qdisc handle, the minor number
> selects the tin. With cake_mq, the per-queue CAKE instances are created
> through qdisc_create_dflt() and never get a handle assigned, so
> sch->handle is 0 for all of them.
>
> For forwarded IPv4 traffic, ip_forward() sets skb->priority from the TOS
> byte via rt_tos2priority() when net.ipv4.ip_forward_update_priority is
> enabled, which is the default. rt_tos2priority() returns 0, 2, 4 or 6,
> all with a major number of 0, which matches the handle of the cake_mq
> children. The minor number is then taken as a tin override and the DSCP
> mapping is skipped.
>
> With diffserv4 and diffserv8 this puts packets into the wrong tins. For
> example, AF13 (TOS byte 0x38) under diffserv4:
>
> ip_forward():
> skb->priority = ip_tos2prio[(0x38 & 0x1E) >> 1]
> = ip_tos2prio[12] = TC_PRIO_INTERACTIVE_BULK = 4
> cake_select_tin():
> TC_H_MAJ(4) == 0 == sch->handle
> tin = bulk_order[4 - 1] = 3 -> Voice
>
> whereas the DSCP table gives diffserv4[0x38 >> 2] = diffserv4[14] = 0,
> i.e. Best Effort. Likewise, AF21, AF31 and AF41 are demoted from Video
> to Best Effort. diffserv3 happens to be unaffected, because the only
> reachable override (priority 2) agrees with its DSCP table.
>
> Fix this by matching skb->priority against the major number of the
> parent cake_mq qdisc when the instance is part of cake_mq.
>
> Fixes: ebc65a873eff ("net/sched: sch_cake: Add cake_mq qdisc for using cake on mq devices")
> Signed-off-by: Jonas Köppeler <j.koeppeler@xxxxxxxxxxxx>

Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>